Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use function rather than var to compile private methods #12990

Merged
merged 3 commits into from Mar 11, 2021
Merged

Use function rather than var to compile private methods #12990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e19112f
Use `function` rather than `var` to compile private methods
nicolo-ribaudo Mar 10, 2021
aa50874
Update fixtures
nicolo-ribaudo Mar 10, 2021
3a244cf
Add class expression tests
nicolo-ribaudo Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...gin-proposal-private-methods/test/fixtures/private-method-loose/class-expression/input.js
View file
Open in desktop
@@ -0,0 +1,7 @@
console.log(class A {
#foo() {}

method() {
this.#foo();
}
});
16 changes: 16 additions & 0 deletions ...in-proposal-private-methods/test/fixtures/private-method-loose/class-expression/output.js
View file
Open in desktop
@@ -0,0 +1,16 @@
var _foo;

console.log((_foo = babelHelpers.classPrivateFieldLooseKey("foo"), class A {
constructor() {
Object.defineProperty(this, _foo, {
value: _foo2
});
}

method() {
babelHelpers.classPrivateFieldLooseBase(this, _foo)[_foo]();
}

}));

function _foo2() {}
7 changes: 7 additions & 0 deletions ...-methods/test/fixtures/private-method-privateFieldsAsProperties/class-expression/input.js
View file
Open in desktop
@@ -0,0 +1,7 @@
console.log(class A {
#foo() {}

method() {
this.#foo();
}
});
16 changes: 16 additions & 0 deletions ...methods/test/fixtures/private-method-privateFieldsAsProperties/class-expression/output.js
View file
Open in desktop
@@ -0,0 +1,16 @@
var _foo;

console.log((_foo = babelHelpers.classPrivateFieldLooseKey("foo"), class A {
constructor() {
Object.defineProperty(this, _foo, {
value: _foo2
});
}

method() {
babelHelpers.classPrivateFieldLooseBase(this, _foo)[_foo]();
}

}));

function _foo2() {}
7 changes: 7 additions & 0 deletions ...el-plugin-proposal-private-methods/test/fixtures/private-method/class-expression/input.js
View file
Open in desktop
@@ -0,0 +1,7 @@
console.log(class A {
#foo() {}

method() {
this.#foo();
}
});
14 changes: 14 additions & 0 deletions ...l-plugin-proposal-private-methods/test/fixtures/private-method/class-expression/output.js
View file
Open in desktop
@@ -0,0 +1,14 @@
var _foo;

console.log((_foo = new WeakSet(), class A {
constructor() {
_foo.add(this);
}

method() {
babelHelpers.classPrivateMethodGet(this, _foo, _foo2).call(this);
}

}));

function _foo2() {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output on main is

var _foo, _temp, _foo2;

console.log((_temp = (_foo = new WeakSet(), class A {
  constructor() {
    _foo.add(this);
  }

  method() {
    babelHelpers.classPrivateMethodGet(this, _foo, _foo2).call(this);
  }

}), _foo2 = function _foo2() {}, _temp));

7 changes: 7 additions & 0 deletions ...posal-private-methods/test/fixtures/private-static-method-loose/class-expression/input.js
View file
Open in desktop
@@ -0,0 +1,7 @@
console.log(class A {
static #foo() {}

method() {
this.#foo();
}
});
12 changes: 12 additions & 0 deletions ...osal-private-methods/test/fixtures/private-static-method-loose/class-expression/output.js
View file
Open in desktop
@@ -0,0 +1,12 @@
var _class, _foo, _temp;

console.log((_temp = (_foo = babelHelpers.classPrivateFieldLooseKey("foo"), _class = class A {
method() {
babelHelpers.classPrivateFieldLooseBase(this, _foo)[_foo]();
}

}), Object.defineProperty(_class, _foo, {
value: _foo2
}), _temp));

function _foo2() {}
7 changes: 7 additions & 0 deletions ...s/test/fixtures/private-static-method-privateFieldsAsProperties/class-expression/input.js
View file
Open in desktop
@@ -0,0 +1,7 @@
console.log(class A {
static #foo() {}

method() {
this.#foo();
}
});
12 changes: 12 additions & 0 deletions .../test/fixtures/private-static-method-privateFieldsAsProperties/class-expression/output.js
View file
Open in desktop
@@ -0,0 +1,12 @@
var _class, _foo, _temp;

console.log((_temp = (_foo = babelHelpers.classPrivateFieldLooseKey("foo"), _class = class A {
method() {
babelHelpers.classPrivateFieldLooseBase(this, _foo)[_foo]();
}

}), Object.defineProperty(_class, _foo, {
value: _foo2
}), _temp));

function _foo2() {}
7 changes: 7 additions & 0 deletions ...in-proposal-private-methods/test/fixtures/private-static-method/class-expression/input.js
View file
Open in desktop
@@ -0,0 +1,7 @@
console.log(class A {
static #foo() {}

method() {
this.#foo();
}
});
10 changes: 10 additions & 0 deletions ...n-proposal-private-methods/test/fixtures/private-static-method/class-expression/output.js
View file
Open in desktop
@@ -0,0 +1,10 @@
var _class;

console.log(_class = class A {
method() {
babelHelpers.classStaticPrivateMethodGet(this, _class, _foo).call(this);
}

});

function _foo() {}