Use function rather than var to compile private methods
#12990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
Spec: Private Methods
PR: Output optimization 🔬
nicolo-ribaudo
commented
Mar 10, 2021
|
|
||
| })); | ||
|
|
||
| function _foo2() {} |
There was a problem hiding this comment.
The output on main is
var _foo, _temp, _foo2;
console.log((_temp = (_foo = new WeakSet(), class A {
constructor() {
_foo.add(this);
}
method() {
babelHelpers.classPrivateMethodGet(this, _foo, _foo2).call(this);
}
}), _foo2 = function _foo2() {}, _temp));
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44199/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a244cf:
|
jridgewell
approved these changes
Mar 10, 2021
JLHwung
approved these changes
Mar 11, 2021
This was referenced Mar 15, 2021
Closed
This was referenced Mar 16, 2021
Closed
Closed
Closed
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on a prototype for #12849 (comment), and I noticed this small output optimization that lets us save a few bytes for each private method.