Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tokens when tokens: true is passed to parseExpression #12939

Merged
merged 1 commit into from Mar 1, 2021
Merged

fix: add tokens when tokens: true is passed to parseExpression #12939

merged 1 commit into from Mar 1, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 1, 2021

Q                       A
Fixed Issues? Fixes #12936
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Assign tokens to top level AST node when tokens: true is passed to parser.getExpression().

JLHwung
JLHwung commented Mar 1, 2021
View reviewed changes
packages/babel-parser/src/types.js
export type ParserOutput = {
comments: $ReadOnlyArray<Comment>,
errors: Array<ParsingError>,
tokens?: $ReadOnlyArray<Token | Comment>,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When tokens: false is passed, tokens does not exist in the output.

@JLHwung JLHwung added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Mar 1, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43148/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a3cd1d0:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
babel-repl-custom-plugin Issue #12936

@JLHwung JLHwung merged commit efdca01 into babel:main Mar 1, 2021
@JLHwung JLHwung deleted the fix-12936 branch March 1, 2021 19:09
@sosukesuzuki sosukesuzuki mentioned this pull request Mar 4, 2021
Merged
2 tasks
This was referenced Mar 5, 2021
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
This was referenced Mar 17, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
@fisker fisker mentioned this pull request May 7, 2021
Closed
1 task
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parseExpression missing tokens
4 participants
@JLHwung @babel-bot @existentialism @nicolo-ribaudo