Remove unstable AST testing #10462
Merged
Remove unstable AST testing #10462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing via babel/babel#12939 for |
sosukesuzuki
force-pushed
the
bump-babel-parser
branch
from
0308d7d
to
c22bea4
Compare
sosukesuzuki
commented
Mar 4, 2021
tests_config/run_spec.js
Outdated
Comment on lines
53
to
61
| "json/json/propertyKey.json", | ||
| (options) => options.parser === "json-stringify", | ||
| ], | ||
| [ | ||
| "flow/function-parentheses/test.js", | ||
| (options) => options.parser.startsWith("babel"), | ||
| "json/json/positive-number.json", | ||
| (options) => options.parser === "json-stringify", | ||
| ], | ||
| ["json/json/json5.json", (options) => options.parser === "json-stringify"], | ||
| ["json/json/array.json", (options) => options.parser === "json-stringify"], |
There was a problem hiding this comment.
In now parserExpression returns AST includes tokens so may break AST idempotency for json-stringify parser.
There was a problem hiding this comment.
I see tokens in ignoredProperties in clean.js. Why does that property still affect idempotence tests?
There was a problem hiding this comment.
Probably ignoreProperties are ignored by messageAST, are not by idempotence tests.
https://github.com/prettier/prettier/blob/main/src/main/massage-ast.js#L13-L18
There was a problem hiding this comment.
It should work, I'll take a look.
There was a problem hiding this comment.
tokens was not ignored in estree-json printer.
thorn0
reviewed
Mar 4, 2021
yarn.lock
Outdated
| resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.13.9.tgz#ca34cb95e1c2dd126863a84465ae8ef66114be99" | ||
| integrity sha512-nEUfRiARCcaVo3ny3ZQjURjHQZUo/JkEw7rLlSZy/psWGnvwXFtPcr6jb7Yb41DVW5LTe6KRq9LGleRNsg1Frw== | ||
|
|
||
| "@babel/parser@^7.1.0", "@babel/parser@^7.12.13", "@babel/parser@^7.13.0", "@babel/parser@^7.13.4": | ||
| version "7.13.4" |
thorn0
approved these changes
Mar 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
babel/babel#12915 has been fixed so we can remove unstable AST testing.
Checklist
✨Try the playground for this PR✨