Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-parser(flow): Add null property to FunctionTypeAnnotation without parens #12930

Merged
merged 3 commits into from Mar 1, 2021
Merged

babel-parser(flow): Add null property to FunctionTypeAnnotation without parens #12930

merged 3 commits into from Mar 1, 2021

Conversation

sosukesuzuki
Copy link
Member

Q                       A
Fixed Issues? Fixes #12915
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43093/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 32055b3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added area: flow pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Feb 27, 2021
nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@JLHwung JLHwung merged commit b62fc3d into babel:main Mar 1, 2021
@sosukesuzuki sosukesuzuki deleted the fix-12915 branch March 2, 2021 06:58
This was referenced Mar 5, 2021
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
This was referenced Mar 17, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

babel-parser(flow): Returns different ASTs with or without parentheses
4 participants
@sosukesuzuki @babel-bot @JLHwung @nicolo-ribaudo