babel-parser(flow): Set this property to null for FunctionTypeAnn…

…otation without parens (#12930) * Add null property to FunctionTypeAnnotation without parens * Update tests * Update tests
babel · Mar 1, 2021 · b62fc3d · b62fc3d
1 parent 265424d
commit b62fc3d
Show file tree

Hide file tree

Showing 13 changed files with 348 additions and 334 deletions.
diff --git a/packages/babel-parser/src/plugins/flow/index.js b/packages/babel-parser/src/plugins/flow/index.js
@@ -1649,6 +1649,7 @@ export default (superClass: Class<Parser>): Class<Parser> =>
         const node = this.startNodeAt(param.start, param.loc.start);
         node.params = [this.reinterpretTypeAsFunctionTypeParam(param)];
         node.rest = null;
+        node.this = null;
         node.returnType = this.flowParseType();
         node.typeParameters = null;
         return this.finishNode(node, "FunctionTypeAnnotation");

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_01/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_01/output.json
@@ -32,6 +32,7 @@
             }
           ],
           "rest": null,
+          "this": null,
           "returnType": {
             "type": "VoidTypeAnnotation",
             "start":19,"end":23,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":23}}

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_02/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_02/output.json
@@ -47,6 +47,7 @@
             }
           ],
           "rest": null,
+          "this": null,
           "returnType": {
             "type": "VoidTypeAnnotation",
             "start":26,"end":30,"loc":{"start":{"line":1,"column":26},"end":{"line":1,"column":30}}

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_05/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_05/output.json
@@ -42,6 +42,7 @@
                     }
                   ],
                   "rest": null,
+                  "this": null,
                   "returnType": {
                     "type": "NumberLiteralTypeAnnotation",
                     "start":24,"end":27,"loc":{"start":{"line":1,"column":24},"end":{"line":1,"column":27}},

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_06/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_06/output.json
@@ -40,6 +40,7 @@
                 }
               ],
               "rest": null,
+              "this": null,
               "returnType": {
                 "type": "BooleanTypeAnnotation",
                 "start":28,"end":35,"loc":{"start":{"line":1,"column":28},"end":{"line":1,"column":35}}

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_07/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_07/output.json
@@ -40,6 +40,7 @@
                 }
               ],
               "rest": null,
+              "this": null,
               "returnType": {
                 "type": "BooleanTypeAnnotation",
                 "start":28,"end":35,"loc":{"start":{"line":1,"column":28},"end":{"line":1,"column":35}}

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_08/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_08/output.json
@@ -36,6 +36,7 @@
             }
           ],
           "rest": null,
+          "this": null,
           "returnType": {
             "type": "BooleanTypeAnnotation",
             "start":20,"end":27,"loc":{"start":{"line":1,"column":20},"end":{"line":1,"column":27}}

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_09/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_09/output.json
@@ -36,6 +36,7 @@
             }
           ],
           "rest": null,
+          "this": null,
           "returnType": {
             "type": "BooleanTypeAnnotation",
             "start":21,"end":28,"loc":{"start":{"line":1,"column":21},"end":{"line":1,"column":28}}

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_10/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_10/output.json
@@ -41,6 +41,7 @@
                   }
                 ],
                 "rest": null,
+                "this": null,
                 "returnType": {
                   "type": "BooleanTypeAnnotation",
                   "start":20,"end":27,"loc":{"start":{"line":1,"column":20},"end":{"line":1,"column":27}}

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_11/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_11/output.json
@@ -32,6 +32,7 @@
             }
           ],
           "rest": null,
+          "this": null,
           "returnType": {
             "type": "UnionTypeAnnotation",
             "start":19,"end":35,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":35}},

diff --git a/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_12/output.json b/...es/babel-parser/test/fixtures/flow/anonymous-function-no-parens-types/good_12/output.json
@@ -32,6 +32,7 @@
             }
           ],
           "rest": null,
+          "this": null,
           "returnType": {
             "type": "FunctionTypeAnnotation",
             "start":19,"end":36,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":36}},
@@ -48,6 +49,7 @@
               }
             ],
             "rest": null,
+            "this": null,
             "returnType": {
               "type": "NumberTypeAnnotation",
               "start":30,"end":36,"loc":{"start":{"line":1,"column":30},"end":{"line":1,"column":36}}