Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all the @babel/* dependencies #12897

Merged
merged 6 commits into from Feb 25, 2021
Merged

Update all the @babel/* dependencies #12897

merged 6 commits into from Feb 25, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 24, 2021 •
edited

Q                       A
Fixed Issues? Closes #10823
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

nicolo-ribaudo
nicolo-ribaudo commented Feb 24, 2021
View reviewed changes
babel.config.js
shippedProposals: true,
modules: false,
exclude: [
"transform-typeof-symbol",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In loose mode preset-env disables this plugin, but we don't have an assumption for it because it was done at the preset level. We might consider adding one in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, maybe good to note in some places if people miss it when turning off loose mode. although I guess if you are doing this you'd probably want to actually do a code diff to see the changes. Would be nice if we had a tool to help with that

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 24, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a4f6af2:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 24, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42612/

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Feb 25, 2021
Merged
JLHwung
JLHwung approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nicolo-ribaudo nicolo-ribaudo merged commit 039eb27 into babel:main Feb 25, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the update-babel-deps branch February 25, 2021 01:46
@nicolo-ribaudo
Copy link
Member Author

You might notice a warning in make build, it's fixed by #12898.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @hzoo @JLHwung