Do not warn for loose of class features in preset-env
#12898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Polish 💅
nicolo-ribaudo
commented
Feb 25, 2021
| @@ -0,0 +1,10 @@ | |||
| [proposal-class-properties]: You are using the "loose: true" option and you are explicitly setting a value for the "setPublicClassFields" assumption. The "loose" option can cause incompatibilities with the other class features plugins, so it's recommended that you replace it with the following top-level option: | |||
There was a problem hiding this comment.
Do you think we should also disable this warning?
It's explicitly setting loose: true, but in @babel/preset-env.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b42389:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42754/ |
existentialism
approved these changes
Feb 25, 2021
nicolo-ribaudo
changed the title
loose warning for class features with preset-envloose of class features in preset-env
This was referenced Mar 5, 2021
Closed
Closed
This was referenced Mar 8, 2021
Closed
Closed
Closed
This was referenced Mar 16, 2021
Closed
Merged
Closed
Closed
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while preparing #12897.
The first commits shows the wrong behavior, the second one fixes it.