New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename index.mjs
to _index.mjs
in @babel/runtime
#12855
Rename index.mjs
to _index.mjs
in @babel/runtime
#12855
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 00b6291:
|
require
condition to @babel/runtime
index.mjs
to _index.mjs
in `@babel/runtime
e2883fe
to
50514e1
Compare
I can confirm that this works in my local gatsby project. |
index.mjs
to _index.mjs
in `@babel/runtimeindex.mjs
to _index.mjs
in @babel/runtime
Thanks 🙏 |
@KyleAMathews We are releasing (https://github.com/babel/babel/actions/runs/591028231) |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41949/ |
@nicolo-ribaudo thanks so much! Confirmed Gatsby is back in business with 7.13.1 🎉 |
I'm going to sleep now, but tomorrow I'll DM you to see how we can add Gatsby as an e2e test 😬 |
Excellent! |
@nicolo-ribaudo thank you truly for the quick turnaround on this. We at Gatsby appreciate this, and so too do our users. We'd love to chat about e2e test, so let us know how we can help ensure we can automate and track this case for the future 👍 |
This should fix #12854, but for some reason webpack still loads the.mjs
version when usingrequire()
🤔Maybe it's a caching problem, but what I see locally is that even uses the.mjs
version even if I remove every mention of.mjs
in@babel/runtime
'spackage.json
The problem is that Webpack 4 always loads
index.mjs
if there are bothindex.js
andindex.mjs
, and there is no way (unless you update the webpack config) to tell it to loadindex.js
.