-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@babel/core v7.13.0 bugs causing builds to fail on new installs #977
Comments
This seems to fix the build, but the Storybook is failing with
|
Related babel issues Config merging (looks like tsdx uses the logic as Gatsby): babel/babel#12851 |
@marklawlor yep looks like the same issue with |
Yes, It is an upstream bug in Babel that many packages are hitting; it's not something TSDX can control. It's also incredibly recent and likely to be fixed by tomorrow if not within the next few hours.
You can also set your
That is also a bug in Babel, babel/babel#12854, filed an hour ago, that was closed 5 minutes ago in babel/babel#12855. TSDX does not even depend on Storybook, it's just included in one of the templates, so a bug in Storybook is also not something TSDX can control. But neither can Storybook as that's a bug in Babel. Would recommend focusing time upstream, but thanks for providing a workaround @marklawlor that should suffice for anyone installing within the next day or so until this is fixed upstream. |
@agilgur5, yep publishing a new version now! https://github.com/babel/babel/runs/1957418439 |
Ah it published when I posted, it should be fixed if you try again https://github.com/babel/babel/releases/tag/v7.13.1 |
Thanks @hzoo, y'all rock! |
@marklawlor if you could confirm the fix and close out, that'd be great. I think the added tests in the Babel PRs cover our use-cases, but might find something else -- please report upstream to help the Babel team if so. |
Hi from another node project Strapi o/ We tested v7.13.1 and it did not fix it for us, we issued a workaround for our community here: strapi/strapi#9482 (comment) |
@agilgur5 v7.13.1 works for a clean install. @derrickmehaffy cheers that fixed the last issue with my project |
Current Behavior
Choose
react with storybook
Errors during the build phase with
It appears the latest version of
@babel/core
broke the config merging.Expected behavior
TSDX can create new projects
Suggested solution(s)
Current workaround is to lock
package.json
to"@babel/core": "7.12.17"
via resolutionsAdditional context
Your environment
The text was updated successfully, but these errors were encountered: