Run jest's tests in the e2e tests #12202
Conversation
nicolo-ribaudo
added
area: tests
PR: Internal 🏠
nicolo-ribaudo
force-pushed
the
e2e-jest
branch
from
1be4a7e
to
5361232
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30394/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e40b57:
|
existentialism
changed the title
|
I'm not sure why |
Yep! |
|
Type error seems to be due to some mismatch between |
Thanks! I've fixed it now. |
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
| bumped = true; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if ("peerDependencies" in content) { | ||
| bumpBabelDependency(content.peerDependencies); | ||
| bumpBabelDependency(content.peerDependencies, "*"); |
There was a problem hiding this comment.
This is because yarn was throwing for latest in the peerDependencies
There was a problem hiding this comment.
Or we can simply remove peerDependencies 😈.
There was a problem hiding this comment.
It will cause problems if one of the packages we test starts using PnP 😛
|
Ok this is ready 🎉 |
| CI=true yarn test-ci-partial packages | ||
| CI=true yarn test-ci-partial e2e/__tests__/babel | ||
| CI=true yarn test-ci-partial e2e/__tests__/transform |
There was a problem hiding this comment.
Could do yarn test-ci-partial --ci packages e2e/__tests__/babel e2e/__tests__/transform?
FWIW I just landed jestjs/jest#10653 which adds test-ci-partial:parallel (which just removes the -i argument) so if you have multiple cores available on CI you can speed it up.
yarn test-ci-partial:parallel --ci --max-workers $(nproc) packages e2e/__tests__/babel e2e/__tests__/transform or something like that
github-actions
bot
added
the
outdated
I looked at
jest's build process and I think that they usetscto build.d.tsfiles, but Babel to compile.tsfiles to.js(@SimenB is this correct?).Since apparently we have some missing TS coverage, this would help preventing future regressions in real-world code.