Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Jest e2e tests in parallel #12233

Closed
wants to merge 2 commits into from
Closed

Run Jest e2e tests in parallel #12233

wants to merge 2 commits into from

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 21, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? #12202 (comment)
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added area: tests PR: Internal 🏠 A type of pull request used for our changelog categories labels Oct 21, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 21, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30787/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c8d8ff7:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung reviewed Oct 21, 2020
View reviewed changes
scripts/integration-tests/e2e-jest.sh Outdated
CI=true yarn test-ci-partial packages
CI=true yarn test-ci-partial e2e/__tests__/babel
CI=true yarn test-ci-partial e2e/__tests__/transform
CI=true yarn test-ci-partial:parallel --ci --max-workers $(nproc) packages e2e/__tests__/babel e2e/__tests__/transform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we delegate to Jest's default on max workers?

@nicolo-ribaudo
Copy link
Member Author

Wait don't approve too much, the failing e2e test is jest 😅

@JLHwung
Copy link
Contributor

JLHwung commented Oct 23, 2020

Yeah apparently circle-ci-bot requested changes so I didn't merge. 😂

@nicolo-ribaudo
Copy link
Member Author

I tried SSH-ing in Circle CI to debug the failure, but I'm getting some ENOMEM: not enough memory errors (when running in parallel) that cause Jest to be in an invalid state end then other tests fail.

I'm going to close this PR for now, since it might just be that the tests need more memory than what Circle CI gives us.

@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo-patch-1 branch January 8, 2021 01:00
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicolo-ribaudo @babel-bot @JLHwung @existentialism @kaicataldo