Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce dependency on lodash functions: values, extends #11798

Merged
merged 21 commits into from Jul 8, 2020
Merged

Reduce dependency on lodash functions: values, extends #11798

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d494925
Replace lodash 'values' usage with Object.keys => .map(obj[key])
jayaddison Jul 6, 2020
24599f6
Block scoping: refactor letReferences, outsideLetReferences as object…
jayaddison Jul 6, 2020
13cebc7
Remove lodash dependency from babel-plugin-transform-block-scoping
jayaddison Jul 6, 2020
28ec04e
Fixup: Add missing Object.keys call
jayaddison Jul 6, 2020
a275a44
Fixup: Update remaining property accessors
jayaddison Jul 6, 2020
1449a30
Coerce Map.values() iterator results into an array via spread operator
jayaddison Jul 6, 2020
94fdc95
Fixup: Map.put -> Map.set
jayaddison Jul 6, 2020
2b6dbe4
Fixup: undo incorrect variable de-duplication
jayaddison Jul 6, 2020
6da36af
Replace array-spread-plus-map combination with Array.from call
jayaddison Jul 7, 2020
85689f2
Extract an extendMap function as an attempt to create an optimization…
jayaddison Jul 7, 2020
a4035c8
Experiment: cast objects to string (eliminates one Map/object differe…
jayaddison Jul 7, 2020
abdd147
Fixup: perform String cast on map keys, not values
jayaddison Jul 7, 2020
68b799a
Revert "Fixup: perform String cast on map keys, not values"
jayaddison Jul 7, 2020
894ff8c
Revert "Experiment: cast objects to string (eliminates one Map/object…
jayaddison Jul 7, 2020
491c093
Experiment: filter keys via Object.prototype.hasOwnProperty.call
jayaddison Jul 7, 2020
bea1b56
Revert "Experiment: filter keys via Object.prototype.hasOwnProperty.c…
jayaddison Jul 7, 2020
2119acc
Migrate back from Map-based reference storage to Object-based storage…
jayaddison Jul 7, 2020
666c1a4
Revert "Migrate back from Map-based reference storage to Object-based…
jayaddison Jul 7, 2020
5ba1cbc
Iterate over a clone of outsideRefs keys
jayaddison Jul 7, 2020
a04e689
Revert "Extract an extendMap function as an attempt to create an opti…
jayaddison Jul 7, 2020
2b03b2e
Fixup: migrate remaining Object property access to Map.get in tdz module
jayaddison Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/babel-plugin-transform-block-scoping/src/index.js
View file
Open in desktop
Expand Up @@ -2,7 +2,6 @@ import { declare } from "@babel/helper-plugin-utils";
import type NodePath from "@babel/traverse";
import type Scope from "@babel/traverse";
import { visitor as tdzVisitor } from "./tdz";
import values from "lodash/values";
import extend from "lodash/extend";
import { traverse, template, types as t } from "@babel/core";

Expand Down Expand Up @@ -545,7 +544,9 @@ class BlockScoping {
this.hoistVarDeclarations();

// turn outsideLetReferences into an array
const args = values(outsideRefs).map(id => t.cloneNode(id));
jayaddison marked this conversation as resolved.
Show resolved Hide resolved
const args = Object.keys(outsideRefs).map(ref =>
t.cloneNode(outsideRefs[ref]),
);
const params = args.map(id => t.cloneNode(id));

const isSwitch = this.blockPath.isSwitchStatement();
Expand Down