Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce dependency on lodash functions: values, extends #11798

Merged
merged 21 commits into from Jul 8, 2020
Merged

Reduce dependency on lodash functions: values, extends #11798

merged 21 commits into from Jul 8, 2020

Commits on Jul 6, 2020

  1. Replace lodash 'values' usage with Object.keys => .map(obj[key])

    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    d494925 View commit details
    Browse the repository at this point in the history

  2. Block scoping: refactor letReferences, outsideLetReferences as object… 

    …s of type Map
    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    24599f6 View commit details
    Browse the repository at this point in the history

  3. Remove lodash dependency from babel-plugin-transform-block-scoping

    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    13cebc7 View commit details
    Browse the repository at this point in the history

  4. Fixup: Add missing Object.keys call

    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    28ec04e View commit details
    Browse the repository at this point in the history

  5. Fixup: Update remaining property accessors

    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    a275a44 View commit details
    Browse the repository at this point in the history

  6. Coerce Map.values() iterator results into an array via spread operator

    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    1449a30 View commit details
    Browse the repository at this point in the history

  7. Fixup: Map.put -> Map.set

    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    94fdc95 View commit details
    Browse the repository at this point in the history

  8. Fixup: undo incorrect variable de-duplication

    @jayaddison
    jayaddison committed Jul 6, 2020
    Copy the full SHA
    2b6dbe4 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Replace array-spread-plus-map combination with Array.from call

    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    6da36af View commit details
    Browse the repository at this point in the history

  2. Extract an extendMap function as an attempt to create an optimization… 

    … boundary
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    85689f2 View commit details
    Browse the repository at this point in the history

  3. Experiment: cast objects to string (eliminates one Map/object differe… 

    …nce per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map )
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    a4035c8 View commit details
    Browse the repository at this point in the history

  4. Fixup: perform String cast on map keys, not values

    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    abdd147 View commit details
    Browse the repository at this point in the history

  5. Revert "Fixup: perform String cast on map keys, not values" 

    This reverts commit abdd147.
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    68b799a View commit details
    Browse the repository at this point in the history

  6. Revert "Experiment: cast objects to string (eliminates one Map/object… 

    … difference per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map )"

This reverts commit a4035c8.
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    894ff8c View commit details
    Browse the repository at this point in the history

  7. Experiment: filter keys via Object.prototype.hasOwnProperty.call

    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    491c093 View commit details
    Browse the repository at this point in the history

  8. Revert "Experiment: filter keys via Object.prototype.hasOwnProperty.c… 

    …all"

This reverts commit 491c093.
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    bea1b56 View commit details
    Browse the repository at this point in the history

  9. Migrate back from Map-based reference storage to Object-based storage… 

    …; access performance appears much improved for Object property access
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    2119acc View commit details
    Browse the repository at this point in the history

  10. Revert "Migrate back from Map-based reference storage to Object-based… 

    … storage; access performance appears much improved for Object property access"

This reverts commit 2119acc.
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    666c1a4 View commit details
    Browse the repository at this point in the history

  11. Iterate over a clone of outsideRefs keys

    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    5ba1cbc View commit details
    Browse the repository at this point in the history

  12. Revert "Extract an extendMap function as an attempt to create an opti… 

    …mization boundary"

This reverts commit 85689f2.
    @jayaddison
    jayaddison committed Jul 7, 2020
    Copy the full SHA
    a04e689 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Fixup: migrate remaining Object property access to Map.get in tdz module

    @jayaddison
    jayaddison committed Jul 8, 2020
    Copy the full SHA
    2b03b2e View commit details
    Browse the repository at this point in the history