Skip to content

fix @babel/traverse can't use path.remove() with noScope #11136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2020
Merged

fix @babel/traverse can't use path.remove() with noScope #11136

merged 1 commit into from
Feb 14, 2020
+15 −1

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #11128
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

@liuxingbaoyu liuxingbaoyu force-pushed the master branch 2 times, most recently from bc87123 to e822c8a Compare February 13, 2020 02:49
nicolo-ribaudo
nicolo-ribaudo reviewed Feb 13, 2020
View reviewed changes
@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse (scope) labels Feb 13, 2020
JLHwung
JLHwung reviewed Feb 13, 2020
View reviewed changes
JLHwung
JLHwung approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit 31b0506 into babel:master Feb 14, 2020
rajasekarm pushed a commit to rajasekarm/babel that referenced this pull request Feb 17, 2020
@liuxingbaoyu @rajasekarm
fix: @babel/traverse can't use path.remove() with noScope (babel#11136)
63f8300
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2020
@liuxingbaoyu liuxingbaoyu deleted the master branch April 7, 2022 09:28
@liuxingbaoyu liuxingbaoyu restored the master branch April 7, 2022 09:29
@liuxingbaoyu liuxingbaoyu deleted the master branch April 7, 2022 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism

@JLHwung JLHwung

@nicolo-ribaudo nicolo-ribaudo

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/traverse noScope can't path.remove()
4 participants
@liuxingbaoyu @existentialism @JLHwung @nicolo-ribaudo