fix: @babel/traverse can't use path.remove() with noScope (#11136)

babel · Feb 14, 2020 · 31b0506 · 31b0506
1 parent 4cfbd64
commit 31b0506
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/babel-traverse/src/path/removal.js b/packages/babel-traverse/src/path/removal.js
@@ -7,7 +7,9 @@ export function remove() {
   this._assertUnremoved();
 
   this.resync();
-  this._removeFromScope();
+  if (!this.opts || !this.opts.noScope) {
+    this._removeFromScope();
+  }
 
   if (this._callRemovalHooks()) {
     this._markRemoved();

diff --git a/packages/babel-traverse/test/removal.js b/packages/babel-traverse/test/removal.js
@@ -33,4 +33,16 @@ describe("removal", function() {
       expect(generateCode(rootPath)).toBe("x = () => {};");
     });
   });
+
+  it("remove with noScope", function() {
+    const ast = parse("a=1");
+    traverse(ast, {
+      AssignmentExpression: function(path) {
+        path.remove();
+      },
+      noScope: true,
+    });
+
+    expect(generate(ast).code).toBe("");
+  });
 });