enable optional chaining by default in @babel/parser

.circleci/config.yml

@@ -48,6 +48,11 @@ executors:
     docker:
       - image: circleci/node:13
     working_directory: ~/babel
+  # e2e-vue-cli test requires chromium
+  node-browsers-executor:
+    docker:
+      - image: circleci/node:13-browsers
+    working_directory: ~/babel
 
 jobs:
   build-standalone:
@@ -153,6 +158,14 @@ jobs:
           at: /tmp/verdaccio-workspace
       - run: ./scripts/integration-tests/e2e-create-react-app.sh
 
+  e2e-vue-cli:
+    executor: node-browsers-executor
+    steps:
+      - checkout
+      - attach_workspace:
+          at: /tmp/verdaccio-workspace
+      - run: ./scripts/integration-tests/e2e-vue-cli.sh
+
 workflows:
   version: 2
   build-standalone:
@@ -189,3 +202,7 @@ workflows:
       - e2e-create-react-app:
           requires:
             - publish-verdaccio
+      - e2e-vue-cli:
+          requires:
+            - publish-verdaccio
+

Makefile

@@ -1,5 +1,5 @@
 FLOW_COMMIT = 09669846b7a7ca5a6c23c12d56bb3bebdafd67e9
-TEST262_COMMIT = 8688c4ab79059c3097098605e69f1ee5eda6c409
+TEST262_COMMIT = 157b18d16b5d52501c4d75ac422d3a80bfad1c17
 TYPESCRIPT_COMMIT = 038d95144d8b93c2799d1732181c89c3d84362d5
 
 FORCE_PUBLISH = "@babel/runtime,@babel/runtime-corejs2,@babel/runtime-corejs3,@babel/standalone,@babel/preset-env-standalone"
@@ -189,7 +189,7 @@ test-typescript-update-whitelist:
 bootstrap-test262:
 	rm -rf build/test262
 	mkdir -p build
-	git clone --branch=master --single-branch --shallow-since=2019-09-01 https://github.com/tc39/test262.git build/test262
+	git clone --branch=master --single-branch --shallow-since=2019-12-01 https://github.com/tc39/test262.git build/test262
 	cd build/test262 && git checkout $(TEST262_COMMIT)
 
 test-test262:

eslint/babel-eslint-parser/package.json

@@ -34,6 +34,7 @@
     "@babel/plugin-proposal-nullish-coalescing-operator": "^7.0.0",
     "@babel/plugin-proposal-optional-chaining": "^7.0.0",
     "@babel/plugin-proposal-pipeline-operator": "^7.0.0",
+    "@babel/plugin-proposal-private-methods": "^7.7.4",
     "@babel/plugin-syntax-bigint": "^7.7.4",
     "@babel/plugin-syntax-dynamic-import": "^7.0.0",
     "@babel/plugin-syntax-export-default-from": "^7.0.0",

eslint/babel-eslint-parser/src/analyze-scope.js

@@ -16,16 +16,16 @@ const flowFlippedAliasKeys = t.FLIPPED_ALIAS_KEYS.Flow.concat([
   "ObjectPattern",
   "RestElement",
 ]);
-const visitorKeysMap = Object.entries(t.VISITOR_KEYS).reduce(function(
-  acc,
-  [key, value],
-) {
-  if (flowFlippedAliasKeys.indexOf(value) === -1) {
-    acc[key] = value;
-  }
-  return acc;
-},
-{});
+
+const visitorKeysMap = Object.entries(t.VISITOR_KEYS).reduce(
+  (acc, [key, value]) => {
+    if (!flowFlippedAliasKeys.includes(value)) {
+      acc[key] = value;
+    }
+    return acc;
+  },
+  {},
+);
 
 const propertyTypes = {
   // loops
@@ -166,6 +166,11 @@ class Referencer extends OriginalReferencer {
     this._visitClassProperty(node);
   }
 
+  // TODO: Update to visit type annotations when TypeScript/Flow support this syntax.
+  ClassPrivateMethod(node) {
+    super.MethodDefinition(node);
+  }
+
   DeclareModule(node) {
     this._visitDeclareX(node);
   }

eslint/babel-eslint-parser/test/babel-eslint-parser.js

@@ -270,7 +270,7 @@ describe("babylon-to-espree", () => {
     assert.strictEqual(babylonAST.tokens[1].type, "Punctuator");
   });
 
-  // Espree doesn't support the private fields yet
+  // Espree doesn't support private fields yet
   it("hash (token)", () => {
     const code = "class A { #x }";
     const babylonAST = parseForESLint(code, {

eslint/babel-eslint-parser/test/fixtures/config/babel.config.js

@@ -18,5 +18,6 @@ module.exports = {
     ["@babel/plugin-proposal-decorators", { decoratorsBeforeExport: false }],
     ["@babel/plugin-proposal-pipeline-operator", { proposal: "minimal" }],
     "@babel/plugin-syntax-bigint",
+    "@babel/plugin-proposal-private-methods",
   ],
 };

eslint/babel-eslint-parser/test/non-regression.js

@@ -1763,27 +1763,77 @@ describe("verify", () => {
     );
   });
 
-  describe("private class properties", () => {
-    it("should not be undefined", () => {
-      verifyAndAssertMessages(
-        `
-            class C {
-              #d = 1;
-            }
-        `,
-        { "no-undef": 1 },
-      );
+  describe("class field declarations", () => {
+    describe("field declarations", () => {
+      it("should not be undefined", () => {
+        verifyAndAssertMessages(
+          `
+              class C {
+                d = 1;
+              }
+          `,
+          { "no-undef": 1 },
+        );
+      });
+
+      it("should not be unused", () => {
+        verifyAndAssertMessages(
+          `
+              export class C {
+                d = 1;
+              }
+          `,
+          { "no-unused-vars": 1 },
+        );
+      });
     });
 
-    it("should not be unused", () => {
-      verifyAndAssertMessages(
-        `
-            export class C {
-              #d = 1;
-            }
-        `,
-        { "no-unused-vars": 1 },
-      );
+    describe("private field declarations", () => {
+      it("should not be undefined", () => {
+        verifyAndAssertMessages(
+          `
+              class C {
+                #d = 1;
+              }
+          `,
+          { "no-undef": 1 },
+        );
+      });
+
+      it("should not be unused", () => {
+        verifyAndAssertMessages(
+          `
+              export class C {
+                #d = 1;
+              }
+          `,
+          { "no-unused-vars": 1 },
+        );
+      });
+    });
+
+    describe("private methods", () => {
+      it("should not be undefined", () => {
+        verifyAndAssertMessages(
+          `
+              class C {
+                #d() {};
+              }
+          `,
+          { "no-undef": 1 },
+        );
+      });
+
+      it("should not be unused", () => {
+        verifyAndAssertMessages(
+          `
+              export class C {
+                #d() {};
+              }
+          `,
+          { "no-unused-vars": 1 },
+        );
+      });
     });
   });
 
@@ -1853,6 +1903,22 @@ describe("verify", () => {
     );
   });
 
+  it("works with classPrivateMethods", () => {
+    verifyAndAssertMessages(
+      `
+        class A { #a(b, c) {} }
+      `,
+    );
+  });
+
+  it("works with arrow function classPrivateProperties", () => {
+    verifyAndAssertMessages(
+      `
+        class A { #a = (a, b) => {}; }
+      `,
+    );
+  });
+
   it("works with optionalCatchBinding", () => {
     verifyAndAssertMessages(
       `

packages/babel-helper-module-transforms/src/rewrite-live-references.js

@@ -182,7 +182,9 @@ const rewriteReferencesVisitor = {
       ref.loc = path.node.loc;
 
       if (
-        path.parentPath.isCallExpression({ callee: path.node }) &&
+        (path.parentPath.isCallExpression({ callee: path.node }) ||
+          path.parentPath.isOptionalCallExpression({ callee: path.node }) ||
+          path.parentPath.isTaggedTemplateExpression({ tag: path.node })) &&
         t.isMemberExpression(ref)
       ) {
         path.replaceWith(t.sequenceExpression([t.numericLiteral(0), ref]));