Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable optional chaining by default in @babel/parser #10817

Closed
wants to merge 19 commits into from
Closed

enable optional chaining by default in @babel/parser #10817

wants to merge 19 commits into from

Conversation

jackisherwood
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10810
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? Y
Tests Added + Pass? Y
Documentation PR Link
Any Dependency Changes?
License MIT

@existentialism existentialism added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser Spec: Optional Chaining labels Dec 5, 2019
@JLHwung JLHwung added this to the v7.8.0 milestone Dec 5, 2019
@existentialism
Copy link
Member

@jackisherwood nice work!

@JLHwung JLHwung added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 5, 2019
@nicolo-ribaudo
Copy link
Member

@jackisherwood FYI, this PR will take a while to be merged because we merge semver-minor PRs right before releasing.

* fix: promise.any requires global.AggregateError

* address review comments
ajafff and others added 10 commits December 28, 2019 16:46
* Dereference imported template tag

* apply fix for OptionalCallExpression as well
* chore: update test262

* chore: ignore untoggleable features
* chore: remove unused isStrictBody

* chore: remove unused eatRelational
* refactor: unify optionalMemberExpression generation

* test: add optional calls invalid typecasts

* fix: do not parse async arrow when call is optional

* test: update test fixtures
…#10935)

* refactor: remove unused invalidTemplateEscapePosition tokenizer state

* fix flow error
…ediate child (#10946)

* fix: scope.inAsync should exclude reference in class property initializers

* chore: add test on await in computed class property

* fix flow error :(
* Override toString in case this function is printed

Related to https://stackoverflow.com/questions/59543968/unexpected-return-value-from-visitor-method

* Don't override `toString` if `wrapper` is true

Override `toString` immediately before returning a newFn, otherwise it will be overridden if wrapper is true

#10949 (comment)

* prettier
@kaicataldo
Copy link
Member

@jackisherwood Do you mind rebasing off of master and fixing the merge conflicts?

* chore: add e2e-vue-cli test

* chore: add node-browsers-executor

* chore: state why node-browsers-executor is required
* test: add test on template

* fix: update lineStart when string contains U+2028/U+2029
* test: add lone import test

* polish: raise recoverable error
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Optional Chaining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable optional chaining by default in @babel/parser
10 participants