Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom instOfHandler result should be cast to boolean #10197

Merged
merged 1 commit into from Jul 10, 2019
Merged

fix: custom instOfHandler result should be cast to boolean #10197

merged 1 commit into from Jul 10, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 10, 2019 •
edited

Q                       A
Fixed Issues? Fixes #10196
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Please refer to #10196 for the background and rationale.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11099/

@existentialism existentialism added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jul 10, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit e88a569 into babel:master Jul 10, 2019
@nicolo-ribaudo
Copy link
Member

Thanks!

@JLHwung JLHwung deleted the to-boolean-inst-of-handler branch July 10, 2019 21:57
@snyk-bot snyk-bot mentioned this pull request Aug 20, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2019
Open
This was referenced Sep 15, 2019
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Sep 23, 2019
Open
Open
This was referenced Oct 3, 2019
Open
Open
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helper.instanceof does not cast [Symbol.hasInstance] call to boolean
5 participants
@JLHwung @babel-bot @nicolo-ribaudo @existentialism @jridgewell