fix: custom instOfHandler result should be cast to boolean (#10197)

babel · Jul 10, 2019 · e88a569 · e88a569
1 parent 4eab157
commit e88a569
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/babel-helpers/src/helpers.js b/packages/babel-helpers/src/helpers.js
@@ -587,7 +587,7 @@ helpers.wrapNativeSuper = helper("7.0.0-beta.0")`
 helpers.instanceof = helper("7.0.0-beta.0")`
   export default function _instanceof(left, right) {
     if (right != null && typeof Symbol !== "undefined" && right[Symbol.hasInstance]) {
-      return right[Symbol.hasInstance](left);
+      return !!right[Symbol.hasInstance](left);
     } else {
       return left instanceof right;
     }

diff --git a/packages/babel-plugin-transform-instanceof/test/fixtures/instanceof/instanceof/exec.js b/packages/babel-plugin-transform-instanceof/test/fixtures/instanceof/instanceof/exec.js
@@ -4,6 +4,11 @@ foo[Symbol.hasInstance]= function () { return true; };
 var bar = {};
 
 expect(bar instanceof foo).toBe(true);
+
+var qux = {};
+qux[Symbol.hasInstance]= function () { return NaN };
+expect(bar instanceof qux).toBe(false);
+
 expect(new String).toBeInstanceOf(String);
 
 //