Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yield for do expression #10101

Merged
merged 3 commits into from Apr 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1,15 @@
async function* asyncGenerator(x) {
const y = do {
let z;
yield 3;
yield await x;
};

return y;
}

const promise = Promise.resolve(5);
const gen = asyncGenerator(promise);
expect(gen.next()).resolves.toMatchObject({ value: 3, done: false });
expect(gen.next()).resolves.toMatchObject({ value: 5, done: false });
expect(gen.next(10)).resolves.toMatchObject({ value: 10, done: true });
@@ -0,0 +1,8 @@
async function* asyncGenerator(x) {
const y = do {
let z;
yield await x;
};

return y;
}
@@ -0,0 +1,3 @@
{
"minNodeVersion": "10.0.0"
}
@@ -0,0 +1,7 @@
async function* asyncGenerator(x) {
const y = yield* async function* () {
let z;
return yield await x;
}();
return y;
}
@@ -0,0 +1,14 @@
function * generator() {
yield 1;
const y = do {
let z;
yield 2;
};

return y;
}

const gen = generator();
expect(gen.next().value).toBe(1);
expect(gen.next().value).toBe(2);
expect(gen.next(3).value).toBe(3);
@@ -0,0 +1,8 @@
function * g() {
const y = do {
let z;
yield 1;
};

return y;
}
@@ -0,0 +1,3 @@
{
"minNodeVersion": "8.0.0"
}
@@ -0,0 +1,7 @@
function* g() {
const y = yield* function* () {
let z;
return yield 1;
}();
return y;
}
23 changes: 19 additions & 4 deletions packages/babel-traverse/src/path/replacement.ts
Expand Up @@ -228,6 +228,7 @@ export function replaceExpressionWithStatements(

const functionParent = this.getFunctionParent();
const isParentAsync = functionParent?.is("async");
const isParentGenerator = functionParent?.is("generator");

const container = t.arrowFunctionExpression([], t.blockStatement(nodes));

Expand Down Expand Up @@ -277,16 +278,30 @@ export function replaceExpressionWithStatements(
callee.arrowFunctionToExpression();

// (() => await xxx)() -> await (async () => await xxx)();
if (
const needToAwaitFunction =
isParentAsync &&
traverse.hasType(
(this.get("callee.body") as NodePath<t.BlockStatement>).node,
"AwaitExpression",
t.FUNCTION_TYPES,
)
) {
);
const needToYieldFunction =
isParentGenerator &&
traverse.hasType(
(this.get("callee.body") as NodePath<t.BlockStatement>).node,
"YieldExpression",
t.FUNCTION_TYPES,
);
if (needToAwaitFunction) {
callee.set("async", true);
this.replaceWith(t.awaitExpression((this as ThisType).node));
// yield* will await the generator return result
if (!needToYieldFunction) {
this.replaceWith(t.awaitExpression((this as ThisType).node));
}
}
if (needToYieldFunction) {
callee.set("generator", true);
this.replaceWith(t.yieldExpression((this as ThisType).node, true));
}

return callee.get("body.body");
Expand Down