yield for do expression #10101
Merged
yield for do expression #10101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
force-pushed
the
tanhauhau/do-expression-yield
branch
from
98c0957
to
7ecf6d5
Compare
JLHwung
added
PR: Bug Fix 🐛
|
I have rebased this PR on Currently we generate incorrect syntax for valid input function* iter(x) {
yield 1;
var y = do {
let temp = yield 2;
temp * temp;
}
} |
JLHwung
approved these changes
Apr 6, 2021
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45040/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d0cd2cc:
|
| @@ -0,0 +1,7 @@ | |||
| async function* asyncGenerator(x) { | |||
| const y = yield* await async function* () { | |||
There was a problem hiding this comment.
I don't think this await is necessary, since yield in async generators automatically awaits its argument.
nicolo-ribaudo
approved these changes
Apr 6, 2021
1 task
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10072, @nicolo-ribaudo maybe can share a bit more about the edge cases you mentioned in #10072 (comment) ?
Fixes #1, Fixes #2