Always register global bindings as exportable (#9865)

babel · Apr 26, 2019 · cf36687 · cf36687
1 parent d7757f6
commit cf36687
Show file tree

Hide file tree

Showing 7 changed files with 167 additions and 11 deletions.
diff --git a/packages/babel-parser/src/util/scope.js b/packages/babel-parser/src/util/scope.js
@@ -90,21 +90,17 @@ export default class ScopeHandler {
 
   declareName(name: string, bindingType: ?BindingTypes, pos: number) {
     let redeclared = false;
+    let scope = this.currentScope();
+
     if (bindingType === BIND_LEXICAL) {
-      const scope = this.currentScope();
       redeclared =
         scope.lexical.indexOf(name) > -1 ||
         scope.functions.indexOf(name) > -1 ||
         scope.var.indexOf(name) > -1;
       scope.lexical.push(name);
-      if (this.inModule && scope.flags & SCOPE_PROGRAM) {
-        this.undefinedExports.delete(name);
-      }
     } else if (bindingType === BIND_SIMPLE_CATCH) {
-      const scope = this.currentScope();
       scope.lexical.push(name);
     } else if (bindingType === BIND_FUNCTION) {
-      const scope = this.currentScope();
       if (this.treatFunctionsAsVar) {
         redeclared = scope.lexical.indexOf(name) > -1;
       } else {
@@ -114,7 +110,7 @@ export default class ScopeHandler {
       scope.functions.push(name);
     } else {
       for (let i = this.scopeStack.length - 1; i >= 0; --i) {
-        const scope = this.scopeStack[i];
+        scope = this.scopeStack[i];
         if (
           (scope.lexical.indexOf(name) > -1 &&
             !(scope.flags & SCOPE_SIMPLE_CATCH && scope.lexical[0] === name)) ||
@@ -126,13 +122,12 @@ export default class ScopeHandler {
         }
         scope.var.push(name);
 
-        if (this.inModule && scope.flags & SCOPE_PROGRAM) {
-          this.undefinedExports.delete(name);
-        }
-
         if (scope.flags & SCOPE_VAR) break;
       }
     }
+    if (this.inModule && scope.flags & SCOPE_PROGRAM) {
+      this.undefinedExports.delete(name);
+    }
     if (redeclared) {
       this.raise(pos, `Identifier '${name}' has already been declared`);
     }

diff --git a/...ndecl-export-function-loose-mode/input.js → ...ecl-export-function-loose-mode-1/input.js b/...ndecl-export-function-loose-mode/input.js → ...ecl-export-function-loose-mode-1/input.js
diff --git a/...l-export-function-loose-mode/options.json → ...export-function-loose-mode-1/options.json b/...l-export-function-loose-mode/options.json → ...export-function-loose-mode-1/options.json
diff --git a/...cl-export-function-loose-mode/output.json → ...-export-function-loose-mode-1/output.json b/...cl-export-function-loose-mode/output.json → ...-export-function-loose-mode-1/output.json
diff --git a/packages/babel-parser/test/fixtures/core/scope/undecl-export-function-loose-mode-2/input.js b/packages/babel-parser/test/fixtures/core/scope/undecl-export-function-loose-mode-2/input.js
@@ -0,0 +1,2 @@
+export { a };
+function a() {}
diff --git a/...es/babel-parser/test/fixtures/core/scope/undecl-export-function-loose-mode-2/options.json b/...es/babel-parser/test/fixtures/core/scope/undecl-export-function-loose-mode-2/options.json
@@ -0,0 +1,4 @@
+{
+  "sourceType": "module",
+  "strictMode": false
+}
diff --git a/...ges/babel-parser/test/fixtures/core/scope/undecl-export-function-loose-mode-2/output.json b/...ges/babel-parser/test/fixtures/core/scope/undecl-export-function-loose-mode-2/output.json
@@ -0,0 +1,155 @@
+{
+  "type": "File",
+  "start": 0,
+  "end": 29,
+  "loc": {
+    "start": {
+      "line": 1,
+      "column": 0
+    },
+    "end": {
+      "line": 2,
+      "column": 15
+    }
+  },
+  "program": {
+    "type": "Program",
+    "start": 0,
+    "end": 29,
+    "loc": {
+      "start": {
+        "line": 1,
+        "column": 0
+      },
+      "end": {
+        "line": 2,
+        "column": 15
+      }
+    },
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExportNamedDeclaration",
+        "start": 0,
+        "end": 13,
+        "loc": {
+          "start": {
+            "line": 1,
+            "column": 0
+          },
+          "end": {
+            "line": 1,
+            "column": 13
+          }
+        },
+        "specifiers": [
+          {
+            "type": "ExportSpecifier",
+            "start": 9,
+            "end": 10,
+            "loc": {
+              "start": {
+                "line": 1,
+                "column": 9
+              },
+              "end": {
+                "line": 1,
+                "column": 10
+              }
+            },
+            "local": {
+              "type": "Identifier",
+              "start": 9,
+              "end": 10,
+              "loc": {
+                "start": {
+                  "line": 1,
+                  "column": 9
+                },
+                "end": {
+                  "line": 1,
+                  "column": 10
+                },
+                "identifierName": "a"
+              },
+              "name": "a"
+            },
+            "exported": {
+              "type": "Identifier",
+              "start": 9,
+              "end": 10,
+              "loc": {
+                "start": {
+                  "line": 1,
+                  "column": 9
+                },
+                "end": {
+                  "line": 1,
+                  "column": 10
+                },
+                "identifierName": "a"
+              },
+              "name": "a"
+            }
+          }
+        ],
+        "source": null,
+        "declaration": null
+      },
+      {
+        "type": "FunctionDeclaration",
+        "start": 14,
+        "end": 29,
+        "loc": {
+          "start": {
+            "line": 2,
+            "column": 0
+          },
+          "end": {
+            "line": 2,
+            "column": 15
+          }
+        },
+        "id": {
+          "type": "Identifier",
+          "start": 23,
+          "end": 24,
+          "loc": {
+            "start": {
+              "line": 2,
+              "column": 9
+            },
+            "end": {
+              "line": 2,
+              "column": 10
+            },
+            "identifierName": "a"
+          },
+          "name": "a"
+        },
+        "generator": false,
+        "async": false,
+        "params": [],
+        "body": {
+          "type": "BlockStatement",
+          "start": 27,
+          "end": 29,
+          "loc": {
+            "start": {
+              "line": 2,
+              "column": 13
+            },
+            "end": {
+              "line": 2,
+              "column": 15
+            }
+          },
+          "body": [],
+          "directives": []
+        }
+      }
+    ],
+    "directives": []
+  }
+}