Fix TypeScript readonly error location (#9887)

babel · Apr 23, 2019 · d7757f6 · d7757f6
1 parent bf17871
commit d7757f6
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/packages/babel-parser/src/plugins/typescript.js b/packages/babel-parser/src/plugins/typescript.js
@@ -743,7 +743,7 @@ export default (superClass: Class<Parser>): Class<Parser> =>
           return;
         default:
           this.raise(
-            node.operator,
+            node.start,
             "'readonly' type modifier is only permitted on array and tuple literal types.",
           );
       }

diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-1/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-1/options.json
@@ -1,7 +1,5 @@
 {
   "sourceType": "module",
-  "plugins": [
-    "typescript"
-  ],
-  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
-}
+  "plugins": ["typescript"],
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:11)"
+}
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-2/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-2/options.json
@@ -3,5 +3,5 @@
   "plugins": [
     "typescript"
   ],
-  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:11)"
 }
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-3/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-3/options.json
@@ -3,5 +3,5 @@
   "plugins": [
     "typescript"
   ],
-  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:11)"
 }
diff --git a/packages/babel-parser/test/fixtures/typescript/types/read-only-4/options.json b/packages/babel-parser/test/fixtures/typescript/types/read-only-4/options.json
@@ -3,5 +3,5 @@
   "plugins": [
     "typescript"
   ],
-  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:NaN)"
+  "throws": "'readonly' type modifier is only permitted on array and tuple literal types. (1:11)"
 }