Update parseHeaders to match node http behavior #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node ignores duplicate entries for certain HTTP headers. It also always converts the `set-cookie` header into an array.
Jessidhia
commented
Nov 28, 2016
| 'expires', 'from', 'host', 'if-modified-since', 'if-unmodified-since', | ||
| 'last-modified', 'location', 'max-forwards', 'proxy-authorization', | ||
| 'referer', 'retry-after', 'user-agent' | ||
| ]; |
There was a problem hiding this comment.
I'm not entirely sure this is needed, as almost all of these headers are only seen in requests, not responses, but it's probably better to match node's behavior.
|
Looks like this also would fix #465, but without affecting other headers. |
|
Looks good. Could you please update the tests for this? |
|
@rubennorte where could I find the appropriate tests? This should only run in a browser... |
|
@rubennorte @Kovensky I added the tests: #874 |
|
Closing in favor of #874. @Kovensky thanks for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node ignores duplicate entries for certain HTTP headers.
It also always converts the
set-cookieheader into an array.See https://nodejs.org/api/http.html#http_message_headers