Make headers with the same name be returned as array #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple headers were joined by comma which is unacceptable for `Set-Cookie`. Now multiple headers are returned as array. Fixes axios#465
rubennorte
requested changes
Apr 6, 2017
lib/helpers/parseHeaders.js
Outdated
| @@ -29,7 +29,15 @@ module.exports = function parseHeaders(headers) { | |||
| val = utils.trim(line.substr(i + 1)); | |||
|
|
|||
| if (key) { | |||
| parsed[key] = parsed[key] ? parsed[key] + ', ' + val : val; | |||
| if (parsed[key]) { | |||
| parsed[key] = utils.isArray(parsed[key]) | |||
There was a problem hiding this comment.
You can use this shorter version:
parsed[key] = [].concat(parsed[key], val);
|
Sorry but we'll finally go with #558 as it's more consistent with Node.js. Thanks for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of being joined with a comma.
Fixes
#465