#4998 Fix strict mode properties access issue. #5152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to the 'caller', 'callee', and 'arguments' properties. TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode.
|
Hey @jasonsaayman , does this look good? |
Closed
7 tasks
|
Closing cause all the issues mentioned are already resolved. Please re-open and tag me if this issue persists or has not been solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freezeMethods run reduceDescriptors method with reducer that is trying to access restricted properties for the strict mode.
Code was crashing on importing following line:
const value = obj[name];where this restricted properties access was made.
This commit fix restricted access in strict mode for 'caller', 'callee', and 'arguments' properties.
TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode.Also simplify named export.
Should fix #4998, #5005 and #5006.