Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0-alpha.1 #5249

Closed
jasonsaayman opened this issue Nov 10, 2022 · 17 comments
Closed

1.2.0-alpha.1 #5249

jasonsaayman opened this issue Nov 10, 2022 · 17 comments

Comments

@jasonsaayman
Copy link
Member

Hi 馃憢

We have released 1.2.0-alpha.1 please can you test this version and provide feedback to us. You can use this by running:

npm i axios@1.2.0-alpha.1

Thanks

@jasonsaayman jasonsaayman pinned this issue Nov 10, 2022
@krutoo
Copy link

krutoo commented Nov 11, 2022

Looks like #5154 has been fixed, thanks to all contributors

@Ashabu
Copy link

Ashabu commented Nov 11, 2022

#5152 is fixed for me as well, thanks to all contributing

@OVO-Josh
Copy link

#5101 still occurs for me unfortunately (thanks to all who contributed though!)

@dhensby
Copy link

dhensby commented Nov 11, 2022

#5000 Doesn't appear to be fixed (at least not under my use-case: Using the settle helper in tests).

@jasonsaayman
Copy link
Member Author

@OVO-Josh #5026 (comment) seems there is not an apparent solution due to this Jest issue jestjs/jest#9771

@jasonsaayman
Copy link
Member Author

Yeah, @dhensby #5000 will probably not happen any time soon. We cannot declare that as part of the public API. I do welcome anyone who needs that to explain or show me their use case, maybe then I can come up with a solution.

@dhensby
Copy link

dhensby commented Nov 11, 2022

@jasonsaayman I think I'll open a new issue specifically about the settle use-case. It's documented in the READMEs as a utility for testing purposes, so seems pretty essential to have the settle helper exported.


edit: see #5254

@irishtomwalsh
Copy link

this fixed issue #5208 for me

@arthurfiorette
Copy link
Contributor

Can we get #4922 into v1.2? Its been there waiting for merge for a while now...

@jasonsaayman
Copy link
Member Author

It seems that TS > JS transpiling is a problem with the latest release. Will see if I can debug that

@Giftia
Copy link

Giftia commented Nov 14, 2022

#5195 Sadly, still occurs.

@tada5hi
Copy link

tada5hi commented Nov 14, 2022

@jasonsaayman would be great if you could create a v1.2.0 release with current features & fixes.

@Max-DVS
Copy link

Max-DVS commented Nov 15, 2022

Thanks! it works again with react native, since 1.0.0 it would complain about restrict mode and had to downgrade to 0.27

@tada5hi
Copy link

tada5hi commented Nov 17, 2022

@jasonsaayman @DigitalBrainJS #5089 is still an issue in v1.2.0-alpha.1

@aymendps
Copy link

Changed from 1.1.3 to this. Can confirm this version fixes the issue in typescript when importing axios leads to axios being undefined.

@jasonsaayman
Copy link
Member Author

This version has now been released, thanks everyone for your help in getting it over the line 馃槃

@jasonsaayman jasonsaayman unpinned this issue Nov 23, 2022
@phloose
Copy link
Contributor

phloose commented Nov 29, 2022

Yeah, @dhensby #5000 will probably not happen any time soon. We cannot declare that as part of the public API. I do welcome anyone who needs that to explain or show me their use case, maybe then I can come up with a solution.

We developed a fetch-based adapter for axios according to the readme in the adapters module. With the new strict export policy regarding lib-exports we cannot use helpers and core functions settle, buildFullPath, buildUrl as @dhensby has said here and in #5254 as well as others have said in #5000. If you can point us to an alternative to using settle or other helpers please let us know. Also if this will not be updated the readme for the adapters module should be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests