New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dep updates, update polyfill handling #2536
Changes from all commits
008aad2
94fc8c8
5c57399
76e8954
9d8f9fa
08f5a6b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,6 @@ | |
"license": "MIT", | ||
"ignore": [ | ||
"**/.*", | ||
"*.iml", | ||
"examples", | ||
"lib", | ||
"node_modules", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,10 @@ | |
|
||
An alert should be shown with the <code>{"name":"axios"}</code> | ||
|
||
<script src="promise.js"></script> | ||
<script> | ||
if (typeof Promise !== "function") | ||
document.write('<script src="//cdnjs.cloudflare.com/ajax/libs/es6-promise/4.1.1/es6-promise.min.js"><\/script>'); | ||
</script> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I recalled a question here. What's the difference between those two promises? And did you really test by IE? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @chinesedfan sorry for the late reply. The Promise here is only really needed for running the unit tests in IE. In my opinion, the unit tests can/should be moved to a brower-less testing approach, which would allow for the removal of any There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @chinesedfan I had some trouble getting the IE VM from Microsoft up and running. Maybe Github actions can help with the problem here. They explicitly support the Windows containers: |
||
<script src="../../dist/axios.js"></script> | ||
<script> | ||
axios.get('./fixture.json').then(function(response) { | ||
|
@@ -18,4 +21,4 @@ | |
</script> | ||
|
||
</body> | ||
</html> | ||
</html> |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proof that
Array.isArray
is well supported and possibly more reliable since it doesn't depend on a string representation check:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#Browser_compatibility