Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dep updates, update polyfill handling #2536

Closed
wants to merge 6 commits into from
Closed

Dep updates, update polyfill handling #2536

wants to merge 6 commits into from

Commits on Feb 23, 2020

  1. Update deps 

     * handles webpack 1 -> 4 migration
    @avindra
    avindra committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    008aad2 View commit details
    Browse the repository at this point in the history

  2. remove promise helpers from dev files 

    assume `Promise` is available, or polyfilled by
the consumer
    @avindra
    avindra committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    94fc8c8 View commit details
    Browse the repository at this point in the history

  3. Remove trim util 

    String.protoype.trim has good coverage (including IE9)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/Trim

Also, the http adapter already uses the native method.
    @avindra
    avindra committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    5c57399 View commit details
    Browse the repository at this point in the history

  4. Remove isArray util. isArray has good coverage, even 

       in IE9. So lets remove the custom polyfill.

 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray

also resolves a few lint issues
    @avindra
    avindra committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    76e8954 View commit details
    Browse the repository at this point in the history

  5. restore promise polyfill via CDN 

    this approach avoids having to include
a fully baked promise solution.

note: the tests already rely on
appspot.com to be up and running
    @avindra
    avindra committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    9d8f9fa View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. use old toString name

    @avindra
    avindra committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    08f5a6b View commit details
    Browse the repository at this point in the history