Prevent subdomains of domains in NO_PROXY from getting proxied #1880
Conversation
|
Hi guys, can I get some eyes on this? |
There was a problem hiding this comment.
Encountered this problem, too.
LGTM.
@nickuraltsev @emilyemorehouse anybody could take a look at this one?
There was a problem hiding this comment.
I would like to ask the original author (@chancedickson ) for the rationale behind this comparison.
This may be related to ndots.
|
As there is no answer, can this be merged @nickuraltsev @emilyemorehouse? |
|
In order to use this library in an enterprise environment, we would need this particular issue to be fixed. It seems minor but it ends up requiring infrastructure architectural remediations. The code review and subsequent merge would be greatly appreciated! Thank you for your awesome work :) |
|
FWIW, this is the same logic used in |
|
Can we get this merged? We need this too. |
|
Merged at #2442 |
Currently, the behaviour for parsing the
no_proxyenv variable is to check that that hostname ends with theno_proxylisted element, and that the element contains the same number of.s as the hostname.This is kind of cumbersome because it forces you to list every possible subdomain of a domain you want not to go through a proxy. For example, if you want any requests to
*.foo.comnot to go through a proxy, you would have to have something like this:set NO_PROXY=bar.foo.com, baz.qux.foo.com, quuz.foo.comI think it would make more sense for
set NO_PROXY=.foo.comto also cover all subdomains of
foo.comas well.Let me know what you guys think!
P.S I found this impossible to work this into the existing tests as they spawn servers on localhost, and I can't create subdomains on localhost without changing
/etc/hosts. Open to suggestions of this