foo.bar.domain.com shouldn't be proxied if no_proxy has .domain.com item

[mapleeit]

Describe the bug

foo.bar.domain.com would still be proxied if no_proxy env has .domain.com item.

Related code is here:

axios/lib/adapters/http.js

Line 122 in fd0c959

proxyElement.match(/\./g).length === parsed.hostname.match(/\./g).length) {

foo.bar.domain.com has 3 dots. On the contrary, .domain.com has 2 dots. So it will not match.

request uses indexOf, which supports this.

var isMatchedAt = hostname.indexOf(noProxyZone.hostname)
var hostnameMatched = (
  isMatchedAt > -1 &&
    (isMatchedAt === hostname.length - noProxyZone.hostname.length)
)

Wondering that is this a but or it's a original designing. If it's a bug, I'm willing to make a PR.

To Reproduce

set system envariable:

export HTTP_PROXY=http://test.proxy.com
export http_proxy=http://test.proxy.com
export HTTPS_PROXY=http://test.proxy.com
export https_proxy=http://test.proxy.com
export NO_PROXY=.domain.com
export no_proxy=.domain.com

axios.get("http://foo.bar.domain.com")
.then(data => console.log(data))
.catch(e => console.log(e))

Expected behavior
Shouldn't proxied.

Environment:

• Axios Version [e.g. 0.19.0-beta.1]

[mapleeit]

I just found that there is already a PR to solve this. #1880

[rjoaopereira]

I would like to ask the original author (@chancedickson ) for the rationale behind this comparison.

I also found this problem and I'm interested in seeing if this is by design.

[cawoodm]

We also noticed today that Axios will proxy 127.0.0.1 even if we have NO_PROXY=127.0.0.*. It seems Axios (unlike fetch) does not understand wildcards.

[cawoodm]

So Axios understands suffixes (without *) - NO_PROXY=.mydomain.com will match myhost.mydomain.com but you cant get a prefix like NO_PROXY=127.0.0. to work no matter which way you turn it.

[nabeelamirch]

Yes it doesn't work with wildcard e.g. *.domain.com will not match foo.domain.com. Could we do something like this:

if (proxyElement.includes("*")) {
   return new RegExp("^" + rule.replace("*","[a-zA-Z_0-9]")+ "$")).test(str);
}

Over here:

axios/lib/adapters/http.js

Line 113 in 42eb9df

shouldProxy = !noProxy.some(function proxyMatch(proxyElement) {

[mapleeit]

0.19.1 already solved this problem, I'm closing this issue.

[nabeelamirch]

I agree with the above, so I will raise another one with the wildcard issue

[nabeelamirch]

I have raised #2864