Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests to urls containing 'javascript' are failing #2646

Closed
arunas-stonis opened this issue Jan 9, 2020 · 13 comments · Fixed by #2679
Closed

Requests to urls containing 'javascript' are failing #2646

arunas-stonis opened this issue Jan 9, 2020 · 13 comments · Fixed by #2679

Comments

@arunas-stonis
Copy link

It seems that axios v0.19.1 introduced a new bug.

The bug comes from #2464

All urls containing javascriptkeyword is throwing XSS error. So, all following urls cannot be used in axios any more:

Here is a link to regexp: https://regexr.com/4rsst

Expected behavior: axios should accept javascript in urls

@StefanOfigo
Copy link

StefanOfigo commented Jan 9, 2020

In addtion, all Urls containing parameter starting with on... are failing.

https://someurl?one=one

Expected behavior: axios should accept parameter starting with on

@fvandenbulcke
Copy link

In addtion, my case:

A static html file loading a bundled script.
The error is thrown when the file absolute path containing "javascript"
Ex: file:///my-path/some-thing-javascript/index.html

@Kolobok12309
Copy link

+1 have problem with path /?online=true

@bstream
Copy link

bstream commented Jan 13, 2020

I have the same problem with ?onlyInStock=true

@fitravel
Copy link

I have the same issue with ?onlyWithFlights=true

@Sayid1
Copy link

Sayid1 commented Jan 16, 2020

A new version is urgently needed to solve this problem

@AlexandreBourdeaudhui
Copy link

AlexandreBourdeaudhui commented Jan 16, 2020

Same here with an internal url which contain javascript.
I go back to the previous version (axios@0.19.0) while waiting for a fix

ZeroCho added a commit to ZeroCho/axios that referenced this issue Jan 16, 2020
ZeroCho added a commit to ZeroCho/axios that referenced this issue Jan 16, 2020
@jonathanbardo
Copy link

I honestly would deprecated 0.19.1 as soon as possible. This can cause major problem on production apps.

@barbudodev
Copy link

I have the same error when the url contains javascript

@baconcheese113
Copy link

image
I get this error after upgrading from 0.19.1 to 0.19.2
Unable to resolve module ./isValidXss from node_modules\axios\lib\helpers\isURLSameOrigin.js

@chinesedfan
Copy link
Collaborator

chinesedfan commented Jan 26, 2020

@baconcheese113 It's a common error occurs in RN. Please reinstall all dependencies in node_modules and do some cleaning cache operations. If you think even a simple Node.js script will thrown such error, feel free to open a new issue with detailed information.

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.