Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS detection breaking react app (still too loose) #2644

Closed
fraywing opened this issue Jan 7, 2020 · 3 comments
Closed

XSS detection breaking react app (still too loose) #2644

fraywing opened this issue Jan 7, 2020 · 3 comments

Comments

@fraywing
Copy link

fraywing commented Jan 7, 2020

Describe the bug
Just upgraded to 19.1, and getting an XSS issue on the new XSS detection changes. (The regex is still too loose)

To Reproduce
Test this URL http://localhost:3000/login?redirect=/work/gigs?onboardingComplete=true with the regex

Expected behavior
Not to pass

Environment:

  • Axios Version [e.g. 0.19.1]

Additional context/Screenshots

@vipzhicheng
Copy link

Same here, my case is ?online=0, trigger the error.

@paradite
Copy link

paradite commented Jan 9, 2020

FYI, offending PRs: #2464 #2529
offending code: https://github.com/axios/axios/blob/v0.19.1/lib/helpers/isValidXss.js

@chinesedfan
Copy link
Collaborator

Let's track in #2646. Forgive me even though this issue is opened first.

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants