Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about isValidXss.js #2663

Closed
JinTak opened this issue Jan 14, 2020 · 5 comments
Closed

Question about isValidXss.js #2663

JinTak opened this issue Jan 14, 2020 · 5 comments

Comments

@JinTak
Copy link

JinTak commented Jan 14, 2020

Describe the issue
I was curious as to why the regex looks for 'on' in the get parameters. I had a parameter called 'onSiteTestComplete=false' but I had to change it to 'isOnSiteTestComplete=false'. Thanks!

https://github.com/axios/axios/blob/master/lib/helpers/isValidXss.js

Environment:

  • Axios Version 0.19.0
  • OS: OSX 10.15.2 Catlina
  • Browser Chrome Version 79.0.3945.117 (Official Build) (64-bit)
@felipecwb
Copy link

I got this error too.
My URL: http://localhost:3001/api/management/users?onlyActive=true

The query string part onlyActive= was caught by regex.

Environment:

  • Axios Version: 0.19.1
  • Firefox Developer Edition 73.0b4 (64-bit)

@315101
Copy link

315101 commented Jan 14, 2020

My 2 cents:
axios version: ^0.19.1

@CammyMurrie
Copy link

see this bug guys #2646

@skflo60
Copy link

skflo60 commented Jan 20, 2020

Hello !
Same problem here with "?onlyActive"
isValidXss returns true

image

@chinesedfan
Copy link
Collaborator

Duplicate of #2646.

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants