Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing: add loadSsoSessionsFrom and expose private util methods to IniLoader #4456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

typing: add loadSsoSessionsFrom and expose private util methods to IniLoader #4456

wants to merge 2 commits into from
+24 −7

Conversation

guiyom-e
Copy link

@guiyom-e guiyom-e commented Jun 23, 2023 •
edited

  • Add the new loadSsoSessionsFrom new method in IniLoader exported type.
  • Expose getHomeDir and getDefaultFilePath util methods in IniLoader exported type.

This can be useful to handle properly the new SSO connection with sessions, like in https://github.com/thomasmichaelwallace/serverless-better-credentials. See issue thomasmichaelwallace/serverless-better-credentials#18

Checklist
  • npm run test passes
  • .d.ts file is updated

@guiyom-e guiyom-e requested a review from a team as a code owner June 23, 2023 12:37
@gozineb
Copy link

gozineb commented Jun 23, 2023

Yes ! Thank you for this PR @guiyom-e

@anaisberg
Copy link

Love this! super useful

@guiyom-e guiyom-e mentioned this pull request Jun 23, 2023
Merged
@ThomasAribart
Copy link

Awesome work 🤩

@MichaelLebrand MichaelLebrand mentioned this pull request Jul 4, 2023
Open
@guiyom-e guiyom-e changed the title typing: add loadSsoSessionsFrom method to IniLoader typing: add loadSsoSessionsFrom and expose private util methods to IniLoader Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guiyom-e @gozineb @anaisberg @ThomasAribart