feat: support the new SSO config format #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anaisberg
commented
Jun 23, 2023
anaisberg
commented
- solves this issue: New SSO config format
anaisberg
changed the title
anaisberg
changed the title
|
Thank you for this work! Could you create a commit with only the feature part, without linting? This would make the review easier, particularly the test part. I'd recommend creating additional commits, if you think linting is required. |
anaisberg
force-pushed
the
allow-new-sso
branch
6 times, most recently
from
08f7a86
to
026aa76
Compare
|
Thank you so much for this fix @anaisberg , been struggling with this ! |
guiyom-e
reviewed
Jun 23, 2023
|
|
||
| export type SsoIniLoader = | ||
| IniLoader & { | ||
| loadSsoSessionsFrom(options: LoadFileOptions): IniFileContent; |
There was a problem hiding this comment.
It won't be necessary anymore when aws/aws-sdk-js#4456 is merged.
|
oh yes - looking forward to this being merged!! |
|
@thomasmichaelwallace any plan for a new release ? |
|
Awesome 🤩 |
|
OK - let me see about getting this made! |
|
checkout version 1.2.0 - feel free to open a PR if it doesn't act like you expect. (I rarely use this project these days, I made the leap to aws-cdk and haven't really looked back!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.