Add bundle shading test #5187
Merged
Add bundle shading test #5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
dongie/bundle-shading-test
branch
6 times, most recently
from
eeb7099
to
f0836ab
Compare
This test ensures that all classes in the SDK bundle artifact are correctly shaded. Unless it is necessary, such as for `org.reactivestreams classes`, all classes found in the bundle JAR should be under the `software.amazon.awssdk` package.
dagnir
force-pushed
the
dongie/bundle-shading-test
branch
from
f0836ab
to
1d6a95a
Compare
zoewangg
approved these changes
May 7, 2024
If the bundle the source of the class, this won't actually compile, becaus SDKClient will not compile.
…into dongie/bundle-shading-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test ensures that all classes in the SDK bundle artifact are correctly shaded.
Unless it is necessary, such as for
org.reactivestreamsclasses, all classes found in the bundle JAR should be under thesoftware.amazon.awssdkpackage.NOTE: These tests currently fail because of incorrect shading. See #5108
Modifications
Testing
Build the
bundleand run the test.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License