Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle shading #5196

Merged
merged 3 commits into from May 7, 2024
Merged

Fix bundle shading #5196

merged 3 commits into from May 7, 2024

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented May 7, 2024

Motivation and Context

Fix #5108

Modifications

  • Exclude dependencies that are already in the bundle from aws-s3-accessgrants-java-plugin
  • Relocate third-party libraries that were missed last time

Testing

Ran the tests added in #5187

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner May 7, 2024 17:47
bundle-sdk/pom.xml Outdated Show resolved Hide resolved
@zoewangg zoewangg enabled auto-merge (squash) May 7, 2024 19:31
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zoewangg zoewangg merged commit b7ee57e into master May 7, 2024
17 checks passed
@zoewangg zoewangg deleted the zoewang/bundleLoggingFix branch May 14, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants