Errors should not be wrapped - Async Waiters (#3430)

aws · Sep 21, 2022 · 5951f6b · 5951f6b
1 parent 821397a
commit 5951f6b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/...-core/src/main/java/software/amazon/awssdk/core/internal/waiters/AsyncWaiterExecutor.java b/...-core/src/main/java/software/amazon/awssdk/core/internal/waiters/AsyncWaiterExecutor.java
@@ -104,10 +104,21 @@ private void runAsyncPollingFunction(Supplier<CompletableFuture<T>> asyncPolling
                             future.completeExceptionally(new UnsupportedOperationException());
                     }
                 } else {
-                    future.completeExceptionally(executorHelper.noneMatchException(responseOrException));
+                    Optional<Throwable> t = responseOrException.right();
+                    if (t.isPresent() && t.get() instanceof Error) {
+                        future.completeExceptionally(t.get());
+                    } else {
+                        future.completeExceptionally(executorHelper.noneMatchException(responseOrException));
+                    }
                 }
             } catch (Throwable t) {
-                future.completeExceptionally(SdkClientException.create("Encountered unexpected exception.", t));
+                Throwable cause = t instanceof CompletionException ? t.getCause() : t;
+
+                if (cause instanceof Error) {
+                    future.completeExceptionally(cause);
+                } else {
+                    future.completeExceptionally(SdkClientException.create("Encountered unexpected exception.", cause));
+                }
             }
         });
     }

diff --git a/...est/src/test/java/software/amazon/awssdk/services/waiters/WaitersAsyncFunctionalTest.java b/...est/src/test/java/software/amazon/awssdk/services/waiters/WaitersAsyncFunctionalTest.java
@@ -198,6 +198,13 @@ public void failureException_shouldThrowException() {
             .hasCauseInstanceOf(SdkClientException.class);
     }
 
+    @Test
+    void errorShouldNotBeWrapped() {
+        when(asyncClient.allTypes(any(AllTypesRequest.class))).thenReturn(CompletableFutureUtils.failedFuture(new OutOfMemoryError()));
+        assertThatThrownBy(() -> asyncWaiter.waitUntilAllTypesSuccess(SdkBuilder::build).join())
+            .hasCauseInstanceOf(Error.class);
+    }
+
     @Test
     public void closeWaiterCreatedWithClient_clientDoesNotClose() {
         asyncWaiter.close();