Errors should not be wrapped - Http (#3431)

* Errors should not be wrapped - Http * Changelog entry * Cast Throwable to Exception * instance check of Exception * Refactor instance check
aws · Sep 21, 2022 · 821397a · 821397a
1 parent ba95988
commit 821397a
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 2 deletions.
diff --git a/.changes/next-release/bugfix-AWSSDKforJavav2-ee04822.json b/.changes/next-release/bugfix-AWSSDKforJavav2-ee04822.json
@@ -0,0 +1,6 @@
+{
+    "category": "AWS SDK for Java v2", 
+    "contributor": "", 
+    "type": "bugfix", 
+    "description": "Fixed issue where errors were being wrapped by SdkClientException"
+}
diff --git a/...n/java/software/amazon/awssdk/core/internal/http/pipeline/stages/AsyncRetryableStage.java b/...n/java/software/amazon/awssdk/core/internal/http/pipeline/stages/AsyncRetryableStage.java
@@ -156,7 +156,11 @@ private void attemptExecute(CompletableFuture<Response<OutputT>> future) {
             responseFuture.whenComplete((response, exception) -> {
 
                 if (exception != null) {
-                    maybeRetryExecute(future, exception);
+                    if (exception instanceof Exception) {
+                        maybeRetryExecute(future, (Exception) exception);
+                    } else {
+                        future.completeExceptionally(exception);
+                    }
                     return;
                 }
 
@@ -175,7 +179,7 @@ private void attemptExecute(CompletableFuture<Response<OutputT>> future) {
             });
         }
 
-        private void maybeRetryExecute(CompletableFuture<Response<OutputT>> future, Throwable exception) {
+        private void maybeRetryExecute(CompletableFuture<Response<OutputT>> future, Exception exception) {
             retryableStageHelper.setLastException(exception);
             retryableStageHelper.updateClientSendingRateForErrorResponse();
             maybeAttemptExecute(future);

diff --git a/...amazon/awssdk/core/internal/http/pipeline/stages/AsyncRetryableStageAdaptiveModeTest.java b/...amazon/awssdk/core/internal/http/pipeline/stages/AsyncRetryableStageAdaptiveModeTest.java
@@ -192,6 +192,21 @@ public void execute_throttlingServiceException_updatesRate() throws Exception {
         verify(tokenBucket, never()).updateClientSendingRate(false);
     }
 
+    @Test
+    public void execute_errorShouldNotBeWrapped() throws Exception {
+        RetryPolicy retryPolicy = RetryPolicy.builder(RetryMode.ADAPTIVE)
+                                             .numRetries(0)
+                                             .build();
+
+        mockChildResponse(new OutOfMemoryError());
+        retryableStage = createStage(retryPolicy);
+
+        SdkHttpFullRequest httpRequest = createHttpRequest();
+        RequestExecutionContext executionContext = createExecutionContext();
+        assertThatThrownBy(() -> retryableStage.execute(httpRequest, executionContext).join())
+            .hasCauseInstanceOf(Error.class);
+    }
+
 
     @Test
     public void execute_unsuccessfulResponse_nonThrottlingError_doesNotUpdateRate() throws Exception {
@@ -298,4 +313,9 @@ private void mockChildResponse(Exception error) throws Exception {
         CompletableFuture<Response<Object>> errorResult = CompletableFutureUtils.failedFuture(error);
         when(mockChildPipeline.execute(any(SdkHttpFullRequest.class), any(RequestExecutionContext.class))).thenReturn(errorResult);
     }
+
+    private void mockChildResponse(Error error) throws Exception {
+        CompletableFuture<Response<Object>> errorResult = CompletableFutureUtils.failedFuture(error);
+        when(mockChildPipeline.execute(any(SdkHttpFullRequest.class), any(RequestExecutionContext.class))).thenReturn(errorResult);
+    }
 }