aws/protocol/rest: V2 REST Encoder Implementation #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
reviewed
Dec 5, 2019
skmcgrail
commented
Dec 6, 2019
skmcgrail
force-pushed
the
encoderV2/rest
branch
from
ec21ba8
to
5c6cfdd
Compare
jasdel
suggested changes
Dec 9, 2019
skmcgrail
force-pushed
the
encoderV2/rest
branch
from
5c6cfdd
to
f740d72
Compare
skmcgrail
force-pushed
the
encoderV2/rest
branch
2 times, most recently
from
f1cecf2
to
2d68280
Compare
jasdel
suggested changes
Dec 11, 2019
skotambkar
reviewed
Dec 12, 2019
skotambkar
reviewed
Dec 12, 2019
skmcgrail
force-pushed
the
encoderV2/rest
branch
from
2d68280
to
fedbd67
Compare
skmcgrail
force-pushed
the
encoderV2/rest
branch
from
fedbd67
to
621b439
Compare
jasdel
approved these changes
Dec 31, 2019
skotambkar
reviewed
Dec 31, 2019
Comment on lines
+40
to
+46
| func (e *Encoder) Encode() error { | ||
| e.req.URL.Path, e.req.URL.RawPath = string(e.path), string(e.rawPath) | ||
| e.req.URL.RawQuery = e.query.Encode() | ||
| e.req.Header = e.header | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
How will this return an error, if it occurred during encoding?
There was a problem hiding this comment.
Ok to return error in this case since, we may want to add validation in the future
jasdel
approved these changes
Dec 31, 2019
jasdel
changed the title
skotambkar
pushed a commit
that referenced
this pull request
Jan 31, 2020
Adds utility for encoding HTTP REST values. Will be used by SDK's generated marshalers.
jasdel
pushed a commit
that referenced
this pull request
Mar 2, 2020
Adds utility for encoding HTTP REST values. Will be used by SDK's generated marshalers.
skmcgrail
added a commit
that referenced
this pull request
Apr 14, 2020
Adds utility for encoding HTTP REST values. Will be used by SDK's generated marshalers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 implementation of the HTTP bindings for use in implementing AWSREST and AWSXML protocols.