REST marshaler prototype using REST Encoder utility #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds utility for encoding HTTP REST values. Will be used by SDK's generated marshalers.
Adds new implementation of JSON encoder for generated marshaler to use in effort to reduce refection in SDK.
skotambkar
force-pushed
the
proto/restUtil
branch
2 times, most recently
from
ce792b7
to
fc72c96
Compare
skotambkar
changed the title
service: prototype operations for APIGateWay and S3 service and use rest encoder utility
skotambkar
changed the title
service: prototype operations for APIGateWay and S3 service and use rest encoder utility service: prototype operations for APIGateWay and S3 service that use rest encoder utility
skotambkar
added
the
blocked
jasdel
suggested changes
Jan 14, 2020
skotambkar
added
pr/work-in-progress
jasdel
suggested changes
Jan 14, 2020
skotambkar
force-pushed
the
proto/restUtil
branch
from
760f5f0
to
e5fd305
Compare
skotambkar
added
pr/ready-to-merge
Modifies the REST v2 encoder to not lower-case values, but use the provided Set/Add headers which will canonicalize the headers.
|
Should be able to rebase this PR with the feature branch, pulling in the updated header encoding. |
…ng using Rest encoder utility
… Rest encoder utility
skotambkar
force-pushed
the
proto/restUtil
branch
from
e5fd305
to
a9a3f41
Compare
skotambkar
removed
the
blocked
skotambkar
force-pushed
the
proto/restUtil
branch
from
a9a3f41
to
9179aea
Compare
skotambkar
force-pushed
the
feature/GeneratedMarshaling
branch
from
1cd370a
to
875184f
Compare
jasdel
reviewed
Feb 11, 2020
Comment on lines
+139
to
+144
| func marshalPutObjectInputShapeAWSXML(r *aws.Request, input *PutObjectInput) error { | ||
| if input.Body != nil { | ||
| r.SetReaderBody(input.Body) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
We'll want to consider how the request body is used across multiple request attempts. This is handled in an awkward way within the SDK's Request type, but leads to the SDK requiring the input.Body to be an io.ReadSeeker. Ideally the SDK should always except an io.Reader, and fail if the request requires a hash to be computed of the body, or disable retries if the body cannot be seeked.
jasdel
force-pushed
the
feature/GeneratedMarshaling
branch
from
875184f
to
2550cb3
Compare
skotambkar
changed the title
service: prototype operations for APIGateWay and S3 service that use rest encoder utility
|
smithy branch includes generated rest (de)serializers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Tests fail, due to pending change required to restrict lower casing header's to unmarshaling.
getApiKeyoperation for apigateway service andputObjectoperation for s3 service. The prototypes use rest encoder utility from PR aws/aws-sdk-go-v2#449