Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iotsecuretunneling and mobile API clients to use correct signing name #1711

Merged
merged 3 commits into from May 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changelog/e4cddb5c443e4c7ab265dd02f294fbde.json
@@ -0,0 +1,9 @@
{
"id": "e4cddb5c-443e-4c7a-b265-dd02f294fbde",
"type": "bugfix",
"description": "Fixes iotsecuretunneling and mobile API clients to use the correct name for signing requests, Fixes [#1686](https://github.com/aws/aws-sdk-go-v2/issues/1686).",
"modules": [
"service/iotsecuretunneling",
"service/mobile"
]
}
2 changes: 1 addition & 1 deletion codegen/sdk-codegen/aws-models/iotsecuretunneling.json
Expand Up @@ -238,7 +238,7 @@
"endpointPrefix": "api.tunneling.iot"
},
"aws.auth#sigv4": {
"name": "iotsecuredtunneling"
"name": "IoTSecuredTunneling"
},
"aws.protocols#awsJson1_1": {},
"smithy.api#documentation": "<fullname>IoT Secure Tunneling</fullname>\n\t\t <p>IoT Secure Tunneling creates remote connections to devices deployed in the\n\t\t\tfield.</p>\n\t\t <p>For more information about how IoT Secure Tunneling works, see <a href=\"https://docs.aws.amazon.com/iot/latest/developerguide/secure-tunneling.html\">IoT\n\t\t\t\tSecure Tunneling</a>.</p>",
Expand Down
5 changes: 4 additions & 1 deletion codegen/sdk-codegen/aws-models/kinesis.json
Expand Up @@ -1277,7 +1277,10 @@
"aws.auth#sigv4": {
"name": "kinesis"
},
"aws.protocols#awsJson1_1": {},
"aws.protocols#awsJson1_1": {
"http": ["http/1.1", "h2"],
"eventStreamHttp": ["h2"]
},
"smithy.api#documentation": "<fullname>Amazon Kinesis Data Streams Service API Reference</fullname>\n <p>Amazon Kinesis Data Streams is a managed service that scales elastically for real-time\n processing of streaming big data.</p>",
"smithy.api#title": "Amazon Kinesis",
"smithy.api#xmlNamespace": {
Expand Down
5 changes: 4 additions & 1 deletion codegen/sdk-codegen/aws-models/lex-runtime-v2.json
Expand Up @@ -42,7 +42,10 @@
"aws.auth#sigv4": {
"name": "lex"
},
"aws.protocols#restJson1": {},
"aws.protocols#restJson1": {
"http": ["http/1.1", "h2"],
"eventStreamHttp": ["h2"]
Comment on lines +46 to +47
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are new to the trait, wonder if there is any guidance on how we should use them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they are documented on the protocols. Basically the priority order of the HTTP protocol version used. eventStreamHttp basically stating only h2 should be used. The v1 SDK models had similar ideas, but I think it was in the metadata section. The AWS SDK for Go never really used these traits since h2 is handled so transparently by the HTTP client.

Each entry in http and eventStreamHttp SHOULD be a valid Application-Layer Protocol Negotiation (ALPN) Protocol ID (for example, http/1.1, h2, etc). Clients SHOULD pick the first protocol in the list they understand when connecting to a service. A client SHOULD assume that a service supports http/1.1 when no http or eventStreamHttp values are provided.

},
"smithy.api#documentation": "<p></p>",
"smithy.api#title": "Amazon Lex Runtime V2"
},
Expand Down
2 changes: 1 addition & 1 deletion codegen/sdk-codegen/aws-models/mobile.json
Expand Up @@ -70,7 +70,7 @@
"endpointPrefix": "mobile"
},
"aws.auth#sigv4": {
"name": "awsmobilehubservice"
"name": "AWSMobileHubService"
},
"aws.protocols#restJson1": {},
"smithy.api#documentation": "<p>\n AWS Mobile Service provides mobile app and website developers with capabilities\n required to configure AWS resources and bootstrap their developer desktop projects\n with the necessary SDKs, constants, tools and samples to make use of those resources.\n </p>",
Expand Down
5 changes: 4 additions & 1 deletion codegen/sdk-codegen/aws-models/transcribe-streaming.json
Expand Up @@ -1447,7 +1447,10 @@
"aws.auth#sigv4": {
"name": "transcribe"
},
"aws.protocols#restJson1": {},
"aws.protocols#restJson1": {
"http": ["http/1.1", "h2"],
"eventStreamHttp": ["h2"]
},
"smithy.api#documentation": "<p>Operations and objects for transcribing streaming speech to text.</p>",
"smithy.api#title": "Amazon Transcribe Streaming Service"
},
Expand Down
2 changes: 1 addition & 1 deletion service/iotsecuretunneling/api_op_CloseTunnel.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/iotsecuretunneling/api_op_DescribeTunnel.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/iotsecuretunneling/api_op_ListTagsForResource.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/iotsecuretunneling/api_op_ListTunnels.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/iotsecuretunneling/api_op_OpenTunnel.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/iotsecuretunneling/api_op_TagResource.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/iotsecuretunneling/api_op_UntagResource.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_CreateProject.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_DeleteProject.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_DescribeBundle.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_DescribeProject.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_ExportBundle.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_ExportProject.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_ListBundles.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_ListProjects.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/mobile/api_op_UpdateProject.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.