Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iotsecuretunneling and mobile API clients to use correct signing name #1711

Merged
merged 3 commits into from May 16, 2022

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented May 16, 2022

Fixes iotsecuretunneling and mobile API clients to use the correct name for signing requests. The models for these APIs contained the wrong name. This PR fixes that, and regenerates the API clients.

Fixes #1686.

Updates the API models the SDK uses to pull in changes that were not
included in automated releases. iotsecuretunnling and mobile model
updates fix aws#1686 where the
request was being signed with the wrong name.
@jasdel jasdel requested a review from skmcgrail May 16, 2022 20:36
Comment on lines +46 to +47
"http": ["http/1.1", "h2"],
"eventStreamHttp": ["h2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are new to the trait, wonder if there is any guidance on how we should use them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they are documented on the protocols. Basically the priority order of the HTTP protocol version used. eventStreamHttp basically stating only h2 should be used. The v1 SDK models had similar ideas, but I think it was in the metadata section. The AWS SDK for Go never really used these traits since h2 is handled so transparently by the HTTP client.

Each entry in http and eventStreamHttp SHOULD be a valid Application-Layer Protocol Negotiation (ALPN) Protocol ID (for example, http/1.1, h2, etc). Clients SHOULD pick the first protocol in the list they understand when connecting to a service. A client SHOULD assume that a service supports http/1.1 when no http or eventStreamHttp values are provided.

@jasdel jasdel merged commit b344246 into aws:main May 16, 2022
@jasdel jasdel deleted the syncApiModels branch May 16, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iotsecuretunneling API cannot be executed because SigningName is incorrect
2 participants