Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): CompositePrincipal synthesizes non-efficient assume role policy #26005

Closed
wants to merge 2 commits into from

Conversation

exoego
Copy link

@exoego exoego commented Jun 16, 2023

Before this PR, CompositePrincipal synthesize a compact principal for policyFragment method but not for addToAssumeRolePolicy method.
After this PR, CompositePrincipal merges principals whose action is same (e.g. sts:AssumeRole) into a single, compact principal.

Closes #23765


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2023 05:36
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 16, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@exoego
Copy link
Author

exoego commented Jun 16, 2023

Hi maintainers.
I am not sure this change requires new integration tests.
Should I add?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f417078
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@exoego exoego closed this Jul 12, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Jul 12, 2023

@exoego apologies for not getting back to you earlier. This doesn't need an integ test, but the logic would have to be implemented somewhere in aws-iam/lib/private/merge-statements.ts or a related file, not when adding a principal. You are welcome to open a new PR with a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(iam): a composite principal is not efficiently synthesized for trust relationship
3 participants