Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iam): CompositePrincipal synthesizes non-efficient assume role policy #25475

Closed
wants to merge 1 commit into from
Closed

fix(iam): CompositePrincipal synthesizes non-efficient assume role policy #25475

wants to merge 1 commit into from

Conversation

exoego
Copy link

@exoego exoego commented May 8, 2023 •
edited

Before this PR, CompositePrincipal synthesize a compact principal for policyFragment method but not for addToAssumeRolePolicy method.
After this PR, CompositePrincipal merges principals whose action is same (e.g. sts:AssumeRole) into a single, compact principal.

Closes #23765

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 8, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 8, 2023 02:13
aws-cdk-automation
aws-cdk-automation requested changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@exoego exoego changed the title feat(iam): Synthesize a compact composite principal in assume role policy fix(iam): Synthesize a compact composite principal in assume role policy May 8, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9179c51
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@exoego exoego changed the title fix(iam): Synthesize a compact composite principal in assume role policy fix(iam): Synthesize a more compact composite principal in assume role policy May 8, 2023
@exoego exoego changed the title fix(iam): Synthesize a more compact composite principal in assume role policy fix(iam): Synthesize a more compact principal in assume role policy May 8, 2023
@exoego exoego changed the title fix(iam): Synthesize a more compact principal in assume role policy fix(iam): CompositePrincipal synthesize non-efficient assume role policy May 8, 2023
@exoego exoego changed the title fix(iam): CompositePrincipal synthesize non-efficient assume role policy fix(iam): CompositePrincipal synthesizes non-efficient assume role policy May 8, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@exoego
Copy link
Author

exoego commented May 30, 2023

Sorry, I will come back soon

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 6, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@exoego
Copy link
Author

exoego commented Jun 16, 2023

Reopened in #26005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(iam): a composite principal is not efficiently synthesized for trust relationship
2 participants
@exoego @aws-cdk-automation