fix(s3-deployment): source markers missing when there are multiple sources #23364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #23321. There is an interesting edge case where if there is any source that has source markers then all sources have to have source markers. This is due to the way the custom resource logic works
aws-cdk/packages/@aws-cdk/aws-s3-deployment/lib/lambda/index.py
Line 64 in 02d0876
aws-cdk/packages/@aws-cdk/aws-s3-deployment/lib/lambda/index.py
Line 137 in 02d0876
All Submissions:
Adding new Construct Runtime Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license