Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3-deployment): source markers missing when there are multiple sources #23364

Merged
merged 3 commits into from Dec 16, 2022
Merged

fix(s3-deployment): source markers missing when there are multiple sources #23364

merged 3 commits into from Dec 16, 2022

Commits on Dec 15, 2022

  1. fix(s3-deployment): source markers missing when there are multiple so… 

    …urces

Follow up to #23321. There is an interesting edge case where if there is
_any_ source that has source markers then _all_ sources have to have
source markers. This is due to the way the custom resource logic works

https://github.com/aws/aws-cdk/blob/02d0876bbb196e9fbeb32d977e7cf65229c8559d/packages/%40aws-cdk/aws-s3-deployment/lib/lambda/index.py#L64

https://github.com/aws/aws-cdk/blob/02d0876bbb196e9fbeb32d977e7cf65229c8559d/packages/%40aws-cdk/aws-s3-deployment/lib/lambda/index.py#L137
    @corymhall
    corymhall committed Dec 15, 2022
    Copy the full SHA
    691cffc View commit details
    Browse the repository at this point in the history

  2. updating integration tests

    @corymhall
    corymhall committed Dec 15, 2022
    Copy the full SHA
    c02fd59 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Merge branch 'main' into corymhall/s3-deployment/fix-markers

    @mergify
    mergify[bot] committed Dec 16, 2022
    Copy the full SHA
    33154f2 View commit details
    Browse the repository at this point in the history