‼️(s3_deployment): SourceMarker removed in 2.55.0 breaking deployment

[tenjaa]

Describe the bug

After updating from 2.54.0 to 2.55.0 my deployment using the s3_deployment breaks with the error message:

'source_markers' and 's3_source_zips' must be the same length

Expected Behavior

When deploying with the new cdk version, I do not want to see a diff.

npx cdk diff with 2.54.0:

[~] Custom::CDKBucketDeployment Dashboard/WebsiteDeployment/CustomResource-c8eefc42ee0a23e7a1eaf8eee51ca8f6c7d2f8554e DashboardWebsiteDeploymentCustomResourcec8eefc42ee0a23e7a1eaf8eee51ca8f6c7d2f8554eA9ADAAAE 
 └─ [~] SourceObjectKeys
     └─ @@ -1,4 +1,4 @@
        [ ] [
        [-]   "d87aa38409ea881a0b0710cac75785074770247efc260c6e38d93ab1cd78de16.zip",
        [+]   "583dcc9b108a4f41ddf685568c9e24869a603da5ad69808ba60cd1adf36d7139.zip",
        [ ]   "d6c6d61e45fa377ee62f1c19899768187aea505cdf161f967ed9fea2d54466cd.zip"
        [ ] ]

Current Behavior

npx cdk diff with 2.55.0:

[~] Custom::CDKBucketDeployment Dashboard/WebsiteDeployment/CustomResource-c8eefc42ee0a23e7a1eaf8eee51ca8f6c7d2f8554e DashboardWebsiteDeploymentCustomResourcec8eefc42ee0a23e7a1eaf8eee51ca8f6c7d2f8554eA9ADAAAE 
 ├─ [~] SourceMarkers
 │   └─ @@ -1,4 +1,3 @@
 │      [ ] [
 │      [-]   {},
 │      [ ]   {}
 │      [ ] ]
 └─ [~] SourceObjectKeys
     └─ @@ -1,4 +1,4 @@
        [ ] [
        [-]   "d87aa38409ea881a0b0710cac75785074770247efc260c6e38d93ab1cd78de16.zip",
        [+]   "583dcc9b108a4f41ddf685568c9e24869a603da5ad69808ba60cd1adf36d7139.zip",
        [ ]   "d6c6d61e45fa377ee62f1c19899768187aea505cdf161f967ed9fea2d54466cd.zip"
        [ ] ]

Reproduction Steps

    new BucketDeployment(this, 'WebsiteDeployment', {
      vpc: props.vpc,
      destinationBucket: websiteBucket,
      sources: [
        Source.asset(path.join(__dirname, '../../frontend'), {
          bundling: {
            image: DockerImage.fromRegistry('public.ecr.aws/docker/library/node'),
            local: {
              tryBundle(outputDir: string) {
                const buildScriptPath = path.join(__dirname, '../../build-frontend.sh');
                spawnSync(`sh`, [buildScriptPath, outputDir]);
                return true;
              },
            },
          },
        }),
        Source.jsonData('licenses.json', licenses),
      ],
    });

Possible Solution

No response

Additional Information/Context

It looks like the issue is introduced by b34d0b7

CDK CLI Version

2.55.0

Framework Version

No response

Node.js Version

18.x

OS

osx

Language

Typescript

Language Version

No response

Other information

No response

[MrArnoldPalmer]

Hey there, thanks for the report. Working on getting a fix out #23364

[MrArnoldPalmer]

Anyone who runs into this please upgrade to v2.55.1 as it includes the fix above.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.